Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cw20 readme #544

Merged
merged 2 commits into from
Nov 11, 2021
Merged

Fix cw20 readme #544

merged 2 commits into from
Nov 11, 2021

Conversation

loloicci
Copy link
Contributor

closes #539

This PR replaces env.sender in CW20's README with info.sender.
And, replace a wrong parameter name recipient in description of Send{contract, amount, msg} with contract.

@CLAassistant
Copy link

CLAassistant commented Nov 11, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

ueco-jb
ueco-jb approved these changes Nov 11, 2021
View reviewed changes
Copy link
Contributor

@ueco-jb ueco-jb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

packages/cw20/README.md
`env.sender` account to the `recipient` account. `contract` must be an
`info.sender` account to the `contract` account. `contract` must be an
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@ueco-jb ueco-jb merged commit 7d3ca58 into CosmWasm:main Nov 11, 2021
@loloicci loloicci deleted the fix-cw20-readme branch November 11, 2021 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ueco-jb ueco-jb ueco-jb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"env.sender" in README of cw20
3 participants
@loloicci @CLAassistant @ueco-jb