Merge pull request #368 from CosmWasm/update-wasmvm.dll-docs

Update wasmvm.dll docs
CosmWasm · Nov 28, 2022 · af817af · af817af
2 parents 6dd44ce + 27e54d6
commit af817af
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 9 deletions.
diff --git a/README.md b/README.md
@@ -28,8 +28,9 @@ We are working on Windows (#288).
 
 ### Builds of libwasmvm
 
-Our system currently supports the following builds. In general we can only support targets
-that are [supported by Wasmer's singlepass backend](https://docs.wasmer.io/ecosystem/wasmer/wasmer-features#compiler-support-by-chipset),
+Our system currently supports the following builds. In general we can only
+support targets that are
+[supported by Wasmer's singlepass backend](https://docs.wasmer.io/ecosystem/wasmer/wasmer-features#compiler-support-by-chipset),
 which for example excludes all 32 bit systems.
 
 <!-- AUTO GENERATED BY libwasmvm_builds.py START -->
@@ -48,12 +49,11 @@ which for example excludes all 32 bit systems.
 | macOS           | x86_64  | static  | 🚫                          |                                                                                                                                        |
 | macOS           | aarch64 | shared  | ✅libwasmvm.dylib           | Fat/universal library with multiple archs ([#294])                                                                                     |
 | macOS           | aarch64 | static  | 🚫                          |                                                                                                                                        |
-| Windows (mingw) | x86_64  | shared  | 🏗wasmvm.dll                 | See [#288]                                                                                                                             |
+| Windows (mingw) | x86_64  | shared  | ✅wasmvm.dll                |                                                                                                                                        |
 | Windows (mingw) | x86_64  | static  | 🚫                          |                                                                                                                                        |
 | Windows (mingw) | aarch64 | shared  | 🚫                          |                                                                                                                                        |
 | Windows (mingw) | aarch64 | static  | 🚫                          |                                                                                                                                        |
 
-[#288]: https://github.com/CosmWasm/wasmvm/pull/288
 [#294]: https://github.com/CosmWasm/wasmvm/pull/294
 
 <!-- AUTO GENERATED BY libwasmvm_builds.py END -->

diff --git a/docs/libwasmvm_builds.py b/docs/libwasmvm_builds.py
@@ -1,4 +1,5 @@
-
+# Run python3 docs/libwasmvm_builds.py and paste output into
+# README.md
 
 oss = ["Linux (glibc)", "Linux (musl)", "macOS", "Windows (mingw)"]
 cpus = ["x86_64", "aarch64"]
@@ -14,7 +15,7 @@
 def wasmer22_supported(os, cpu, build_type):
     if os == "Windows (mingw)":
         if cpu == "x86_64" and build_type == "shared":
-            return UNDER_CONSTRUCTION + "wasmvm.dll"
+            return SUPPORTED + "wasmvm.dll"
         else:
             return UNSUPPORTED
     if os == "macOS" and build_type == "static":
@@ -40,8 +41,6 @@ def wasmer22_supported(os, cpu, build_type):
     return UNKNOWN
 
 def get_note(os, cpu, build_type):
-    if os == "Windows (mingw)" and cpu == "x86_64" and build_type == "shared":
-        return "See [#288]"
     if os == "Linux (glibc)" and cpu == "x86_64" and build_type == "static":
         return "Would link libwasmvm statically but glibc dynamically as static glibc linking is not recommended. Potentially interesting for Osmosis."
     if os == "Linux (musl)" and build_type == "shared":
@@ -52,7 +51,6 @@ def get_note(os, cpu, build_type):
 
 def get_links():
     return """
-[#288]: https://github.com/CosmWasm/wasmvm/pull/288
 [#294]: https://github.com/CosmWasm/wasmvm/pull/294
 """