Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBCReceiveResponse Messages/Submessages #236

Closed
alpe opened this issue Jun 25, 2021 · 1 comment · Fixed by #242
Closed

IBCReceiveResponse Messages/Submessages #236

alpe opened this issue Jun 25, 2021 · 1 comment · Fixed by #242
Labels
bug Something isn't working

Comments

@alpe
Copy link
Contributor

alpe commented Jun 25, 2021

The response type still contains both:
https://github.com/CosmWasm/wasmvm/blob/main/types/ibc.go#L123
@alpe alpe added the production Feature needed for production readiness label Jul 1, 2021
@alpe alpe mentioned this issue Jul 5, 2021
Merged
10 tasks
@webmaster128 webmaster128 added bug Something isn't working and removed production Feature needed for production readiness labels Jul 6, 2021
@webmaster128
Copy link
Member

This was updates in CosmWasm but not here. IBCReceiveResponse.Submessages is always empty and IBCReceiveResponse.Messages has the wrong type. So deserialization JSON into IBCReceiveResponse will probably fail.

@uint uint mentioned this issue Jul 6, 2021
Merged
faddat pushed a commit to faddat/go-cosmwasm that referenced this issue Dec 10, 2021
@ethanfrey
Merge pull request CosmWasm#236 from CosmWasm/moniker-name
789ef54 
Use moniker != chain-id to make script easier to understand
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update IBCReceiveResponse CosmWasm/wasmvm
2 participants
@alpe @webmaster128