Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use different debug handler by default #453

Merged
merged 2 commits into from
Aug 30, 2023
Merged

Use different debug handler by default #453

merged 2 commits into from
Aug 30, 2023

Conversation

webmaster128
Copy link
Member

@webmaster128 webmaster128 commented Aug 29, 2023 •
edited
Loading

Instead of relying whatever cosmwasm-vm does, we print timestamp and gas remaining.

I'm primarily putting this here to show where/how those things can be customized.

See also CosmWasm/cosmwasm#1841.

maurolacy
maurolacy approved these changes Aug 29, 2023
View reviewed changes
Copy link
Contributor

@maurolacy maurolacy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

libwasmvm/src/calls.rs Outdated Show resolved Hide resolved
@webmaster128 webmaster128 added this to the 1.4.0 milestone Aug 30, 2023
@webmaster128 webmaster128 force-pushed the use-different-set_debug_handler branch from ebf8afe to 0dc1dd0 Compare August 30, 2023 09:47
@webmaster128 webmaster128 marked this pull request as ready for review August 30, 2023 09:57
@webmaster128 webmaster128 mentioned this pull request Aug 30, 2023
Closed
chipshort
chipshort approved these changes Aug 30, 2023
View reviewed changes
Copy link
Collaborator

@chipshort chipshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@webmaster128 webmaster128 merged commit 139836c into main Aug 30, 2023
@webmaster128 webmaster128 deleted the use-different-set_debug_handler branch August 30, 2023 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maurolacy maurolacy maurolacy approved these changes

@chipshort chipshort chipshort approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@webmaster128 @chipshort @maurolacy