-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: fix readme button hidden cookiebanner #5546
base: develop
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
app/web/package.json
Outdated
"packageManager": "[email protected]+sha512.a6b2f7906b721bba3d67d4aff083df04dad64c399707841b7acf00f6b133b7ac24255f2652fa22ae3534329dc6180534e98d17432037ff6fd140556e2bb3137e" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's this for? Was this on purpose?
Heyyo you can run the tests via |
3f5fbb3
to
c080ff1
Compare
textAlign: "center", | ||
}} | ||
> | ||
Read more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't forget to put this in i18n instead (the translation tool). If you search i18n you should find some examples.
border: "none", | ||
}} | ||
> | ||
Read more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here with translation
Location looks good and it's working! Just one small UI thing: When I hover it adds a big square of a slightly green background color. Would you mind removing the background color on hover and just have it be cursor: pointer? Screen.Recording.2025-02-12.at.5.59.06.PM.mov |
Closes #4128
Not sure how to run tests or when to add them so please feel free to comment or feedback!
Backend checklist
ruff check --select I --fix . && ruff check . && ruff format .
inapp/backend
develop
if necessary for linear migration historyWeb frontend checklist
yarn format
yarn lint --fix