Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: fix readme button hidden cookiebanner #5546

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

kelvinscuesta
Copy link

Closes #4128

  1. Move read more button into a container to allow for flexbox to handle sizing and spacing
  2. Fix width sizing on mobile, tablet, and ultra wide screens of the introduction on landing page

Not sure how to run tests or when to add them so please feel free to comment or feedback!

Backend checklist

  • Formatted my code by running ruff check --select I --fix . && ruff check . && ruff format . in app/backend
  • Added tests for any new code or added a regression test if fixing a bug
  • All tests pass
  • Run the backend locally and it works
  • Added migrations if there are any database changes, rebased onto develop if necessary for linear migration history

Web frontend checklist

  • Formatted my code with yarn format
  • There are no warnings from yarn lint --fix
  • There are no console warnings when running the app
  • Added tests where relevant
  • All tests pass
  • Clicked around my changes running locally and it works
  • Checked Desktop, Mobile and Tablet screen sizes

@kelvinscuesta kelvinscuesta requested review from aapeliv, nabramow and a team January 27, 2025 06:04
Copy link

vercel bot commented Jan 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
couchers ✅ Ready (Inspect) Visit Preview Feb 11, 2025 6:47pm

Comment on lines 111 to 110
"packageManager": "[email protected]+sha512.a6b2f7906b721bba3d67d4aff083df04dad64c399707841b7acf00f6b133b7ac24255f2652fa22ae3534329dc6180534e98d17432037ff6fd140556e2bb3137e"
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's this for? Was this on purpose?

@nabramow
Copy link
Member

Heyyo you can run the tests via yarn test! All the scripts we have are in the package.json under scripts also for future reference!

@nabramow
Copy link
Member

Okay just pulled the branch to take a look! I'm still seeing the "Read More" button covered by the cookie banner on Desktop, and the little arrow is touching the border now:

Screenshot 2025-01-26 at 10 20 20 PM Screenshot 2025-01-26 at 10 20 39 PM

Looking at the ticket again, we might have wrote it confusingly as the example design is actually in the comments (if so sorry ooops). "Read More" should be moved to the left below "Free forever. Community-led. Non-profit. Modern" like this:

190621213-236aa0b8-7ce0-486e-88a8-8706929b25cc

Any questions, just shout!

@kelvinscuesta kelvinscuesta force-pushed the web/refactor/read-more-button branch from 3f5fbb3 to c080ff1 Compare February 11, 2025 18:37
textAlign: "center",
}}
>
Read more
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to put this in i18n instead (the translation tool). If you search i18n you should find some examples.

border: "none",
}}
>
Read more
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here with translation

@nabramow
Copy link
Member

Location looks good and it's working! Just one small UI thing: When I hover it adds a big square of a slightly green background color. Would you mind removing the background color on hover and just have it be cursor: pointer?

Screen.Recording.2025-02-12.at.5.59.06.PM.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cookie banner hides "Read More" on landing page
2 participants