fix(notification bar): add react memo to replace shouldcomponentupdate

Coursemology · Mar 17, 2022 · 0714d3a · 0714d3a
1 parent f30bd2f
commit 0714d3a
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/...s/course/assessment/containers/MaterialUploader/__test__/__snapshots__/index.test.js.snap b/...s/course/assessment/containers/MaterialUploader/__test__/__snapshots__/index.test.js.snap
@@ -146,7 +146,7 @@ exports[`<MaterialList /> renders the component with materials 1`] = `
     </ReactTooltip>
   </WithStyles(List)>
   <WithStyles(Divider) />
-  <NotificationBar
+  <Memo(NotificationBar)
     autoHideDuration={5000}
   />
 </Fragment>

diff --git a/client/app/lib/components/NotificationBar.jsx b/client/app/lib/components/NotificationBar.jsx
@@ -66,4 +66,7 @@ NotificationBar.propTypes = {
   autoHideDuration: PropTypes.number,
 };
 
-export default NotificationBar;
+export default React.memo(
+  NotificationBar,
+  (prevProps, nextProps) => prevProps.notification === nextProps.notification,
+);