Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatting in Jupyter Notebooks #516

Merged
merged 3 commits into from
Mar 14, 2024

Conversation

amandarichardsonn
Copy link
Contributor

@amandarichardsonn amandarichardsonn commented Mar 12, 2024

Jupyter notebook math expressions were not rendering locally or in docker container - to test run make docs and make docks.

  1. Added the sphinx.ext.mathjax extension in conf.py
  2. Set mathjax_path: path to the MathJax.js file

@amandarichardsonn amandarichardsonn changed the title mathjax implement Formatting in Jupyter Notebooks Mar 12, 2024
Copy link

codecov bot commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.75%. Comparing base (3c271f3) to head (32128d8).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #516      +/-   ##
===========================================
+ Coverage    90.70%   90.75%   +0.05%     
===========================================
  Files           60       60              
  Lines         3839     3839              
===========================================
+ Hits          3482     3484       +2     
+ Misses         357      355       -2     

see 1 file with indirect coverage changes

@mellis13 mellis13 requested a review from al-rigazzi March 13, 2024 18:15
Copy link
Collaborator

@al-rigazzi al-rigazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the docs are getting better and better!

@amandarichardsonn amandarichardsonn merged commit 4722b4f into CrayLabs:develop Mar 14, 2024
42 checks passed
@amandarichardsonn amandarichardsonn deleted the jupyter-fix branch March 14, 2024 18:27
@amandarichardsonn amandarichardsonn added bug: minor A minor bug area: docs Issues related to documentation repo: smartsim Issues related to SmartSim infrastructure library labels Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: docs Issues related to documentation bug: minor A minor bug repo: smartsim Issues related to SmartSim infrastructure library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants