-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update watchdog dependency #540
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #540 +/- ##
===========================================
- Coverage 90.76% 90.70% -0.07%
===========================================
Files 65 65
Lines 4528 4498 -30
===========================================
- Hits 4110 4080 -30
Misses 418 418
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! The only thing holding up the approval for me is I'm curious why the self._observer
starts and stops don't have their # type: ignore
comments removed because it looks like BaseObserver
is a watchdog
class.
Answered offline. Should be good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for answering my lingering question!
Updated watchdog dependency pin to next major version and removed
type: ignore
where possible due to new type hints added to watchdog