Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump manifest.json version to 0.0.4 #563

Merged
merged 3 commits into from
Apr 23, 2024

Conversation

AlyssaCote
Copy link
Contributor

The manifest.json version needs to be bumped from 0.0.3 to 0.0.4 to match the version of SmartDashboard.

@AlyssaCote AlyssaCote requested a review from MattToast April 22, 2024 20:18
@AlyssaCote AlyssaCote self-assigned this Apr 23, 2024
Copy link
Member

@MattToast MattToast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending conflicts!! Thanks for keeping this up to date!

Copy link

codecov bot commented Apr 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.51%. Comparing base (62f2e8c) to head (c610bda).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #563      +/-   ##
===========================================
+ Coverage    69.28%   71.51%   +2.23%     
===========================================
  Files           66       66              
  Lines         4571     4571              
===========================================
+ Hits          3167     3269     +102     
+ Misses        1404     1302     -102     
Files Coverage Δ
smartsim/_core/utils/serialize.py 94.59% <ø> (ø)

... and 36 files with indirect coverage changes

@AlyssaCote AlyssaCote merged commit 399886b into CrayLabs:develop Apr 23, 2024
36 checks passed
@amandarichardsonn amandarichardsonn added repo: smartsim Issues related to SmartSim infrastructure library smartdashboard Related to SmartDashboard Repo labels Apr 25, 2024
ankona pushed a commit to ankona/SmartSim that referenced this pull request May 6, 2024
The `manifest.json` version needs to be bumped from `0.0.3` to `0.0.4`
to match the version of SmartDashboard.

[ committed by @AlyssaCote ]
[ reviewed by @MattToast ]
ankona pushed a commit to ankona/SmartSim that referenced this pull request May 7, 2024
The `manifest.json` version needs to be bumped from `0.0.3` to `0.0.4`
to match the version of SmartDashboard.

[ committed by @AlyssaCote ]
[ reviewed by @MattToast ]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
repo: smartsim Issues related to SmartSim infrastructure library smartdashboard Related to SmartDashboard Repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants