A couple of fixes for building against the latest libraries. #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 3, 2019 09:50
- Aurora.Gray now takes an int for brightness - Slack now sets logging/debug options in the contructor
Codecov Report
@@ Coverage Diff @@
## master #9 +/- ##
==========================================
- Coverage 37.41% 37.16% -0.26%
==========================================
Files 1 1
Lines 147 148 +1
==========================================
Hits 55 55
- Misses 90 91 +1
Partials 2 2
Continue to review full report at Codecov.
|
Crazybus
requested changes
Oct 3, 2019
moonsla.go
Outdated
|
|
||
| api := slack.New( | ||
| slackToken, | ||
| slack.OptionDebug(true), |
There was a problem hiding this comment.
Could you switch this back to the default of false? Making it configurable would also be ok.
With this enabled I'm getting spammed by logs:
slack-bot: 2019/10/03 08:39:10 websocket_managed_conn.go:326: Sending PING 1
slack-bot: 2019/10/03 08:39:10 websocket_managed_conn.go:369: Incoming Event: {"type":"pong","timestamp":1570084750,"reply_to":1}
slack-bot: 2019/10/03 08:39:40 websocket_managed_conn.go:326: Sending PING 2
slack-bot: 2019/10/03 08:39:40 websocket_managed_conn.go:369: Incoming Event: {"type":"pong","timestamp":1570084780,"reply_to":2}
Suggested change
| slack.OptionDebug(true), | |
| slack.OptionDebug(false), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.