Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve input matching feature. #72

Merged

Conversation

facetoe
Copy link
Contributor

@facetoe facetoe commented Jun 14, 2017

Underline matched text and grey out non matching entries. Now matches input anywhere in the text.

Underline matched text and grey out non matching entries.
@Epskampie
Copy link

Epskampie commented Aug 23, 2017

I tested this functionality, and it's great! Really makes "finding as you type" in recent history a lot more visually clear. The "manage history" window could also benefit from this.

One suggestion though:

  • As soon as you start typing the first match should be selected. Right now it waits until there is only 1 match, but sometimes the first one is already correct, and I just want to paste it without having to press down.
  • If you keep typing, if the currently selected items doesn't match anymore, it should once again select the first match.

@facetoe
Copy link
Contributor Author

facetoe commented Aug 24, 2017

Yep, both suggestions sound good. I'll have a go at implementing this when I get the chance.

@facetoe
Copy link
Contributor Author

facetoe commented Aug 24, 2017

@Epskampie, I've implemented your suggestions.

@facetoe facetoe force-pushed the input_selection_improvements branch from 8d6e07d to faaed96 Compare August 24, 2017 06:40
@Epskampie
Copy link

Awesome, tested and works great! Hopefully a maintainer will merge soon, but in the meantime I'm already enjoying this version. :-)

@facetoe
Copy link
Contributor Author

facetoe commented Aug 24, 2017

Excellent :) @CristianHenzel pops in on occasion and merges PRs.

@CristianHenzel CristianHenzel merged commit 4d45052 into CristianHenzel:master May 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants