Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add file install method #242

Merged
merged 4 commits into from
Sep 6, 2022
Merged

add file install method #242

merged 4 commits into from
Sep 6, 2022

Conversation

juju4
Copy link
Contributor

@juju4 juju4 commented Aug 20, 2022

Allows to install from a file local to orchestrator

@carlosmmatos
Copy link
Contributor

Hi @juju4 - thanks for opening the PR. Would you mind expanding on your specific scenario in order to better understand the ask here?

@juju4
Copy link
Contributor Author

juju4 commented Aug 28, 2022

This allows to deploy directly from orchestrator system without need for console credentials or additional system (web server to store files)

@carlosmmatos
Copy link
Contributor

@juju4 We can probably refine this a bit to be more inline with the project. For example, we're not going to implement a copy feature as that can be done in a pre-tasks outside the collection itself. However, we do believe in supporting local file path installations for all operating systems so this is something we would like to add.

If you agree with the above, then we can contribute our recommended changes to your PR.

@carlosmmatos carlosmmatos force-pushed the devel-file branch 2 times, most recently from 4a47ea5 to a15b959 Compare August 30, 2022 14:42
@carlosmmatos
Copy link
Contributor

@juju4 Let me know if you are on board with the current proposed changes I have pushed to your PR.

Basically, this is how you would use it to get that same functionality you are after:

---
- hosts: all
  tasks:
  - name: Copy falcon-sensor to remote
    ansible.builtin.copy:
      src: <path to falcon-sensor on orchestrator>
      dest: /tmp/falcon.deb

  roles:
  - role: crowdstrike.falcon.falcon_install
    vars:
      falcon_install_method: file
      falcon_localfile_path: /tmp/falcon.deb
      falcon_localfile_cleanup: yes

@carlosmmatos carlosmmatos marked this pull request as draft August 30, 2022 14:53
@juju4
Copy link
Contributor Author

juju4 commented Sep 3, 2022

LGTM. Thanks!

@carlosmmatos carlosmmatos marked this pull request as ready for review September 5, 2022 13:42
@redhatrises redhatrises merged commit a593e76 into CrowdStrike:main Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants