Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue with removing aid for master image prep in falcon_configure #255

Merged

Conversation

carlosmmatos
Copy link
Contributor

closes #254

When trying to remove the aid to prep for master image/clone, there was an issue with embedding the falcon_remove_aid functionality into the configure task. This was causing this task to always run:

- name: CrowdStrike Falcon | Configure Falcon Sensor Options (Linux)

By extracting the actual tasks needed to remove the aid - and prevent the service from being bounced, a few changes were introduced to this PR:

  • No longer need a handler for this role. The sensor should be bounced immediately after registering changes. This allows users to run a play where they add the CID and other config items, then want to remove the aid to prep an image. Example playbook:
---
- name: Configure and prep falcon
  hosts: all
  tasks:
    - name: Set CID and tags
      ansible.builtin.include_role:
        name: crowdstrike.falcon.falcon_configure
      vars:
        falcon_client_id: "{{ lookup('env', 'FALCON_CLIENT_ID') }}"
        falcon_client_secret: "{{ lookup('env', 'FALCON_CLIENT_SECRET') }}"
        falcon_tags: 'testing123'

    - name: Delete Agent ID to prep Master Image
      ansible.builtin.include_role:
        name: crowdstrike.falcon.falcon_configure
      vars:
        falcon_option_set: no
        falcon_remove_aid: yes
  • Updated main.yml to include new remove_aid.yml task
  • Updated molecule testing to reflect new changes
  • Added changelog fragment

@redhatrises redhatrises merged commit 6ace99b into CrowdStrike:main Sep 16, 2022
@redhatrises redhatrises deleted the 254-fix-failing-aid-master-prep branch September 16, 2022 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete Agent ID failing in crowdstrike.falcon.falcon_configure
2 participants