Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix examples regarding falcon_aph/aph #447

Merged
merged 1 commit into from
Mar 8, 2024
Merged

Fix examples regarding falcon_aph/aph #447

merged 1 commit into from
Mar 8, 2024

Conversation

quasd
Copy link
Contributor

@quasd quasd commented Feb 14, 2024

Affected roles:

  • crowdstrike.falcon.falcon_configure

Affected modules:

  • falconctl

All the documentation tells you to configure proxy with falcon_aph/aph with protocol included.

falcon_aph: "http://{{ proxy__host }}"

However if you do that you will get the following

CrowdStrike(4): Connect: Unable to resolve http://<Proxy FQDN retracted>, getaddrinfo returned -2

To get proxy working you need to use following.

falcon_aph: "{{ proxy__host }}"

And the connection will work with proxy

CrowdStrike(4): trying to connect to <Proxy FQDN retracted>:8080
CrowdStrike(4): ProxyConnect: Connected successfully to "<retracted CS server name>:443" via proxy "<Proxy FQDN retracted>:8080" 

This pull request aims to fix the documentation to reflect reality.

*used incorrect email in commit so had to redo.

@carlosmmatos carlosmmatos self-assigned this Mar 7, 2024
@carlosmmatos carlosmmatos added documentation Improvements or additions to documentation ok-to-test Run tests and removed ok-to-test Run tests labels Mar 7, 2024
@carlosmmatos carlosmmatos added ok-to-test Run tests and removed ok-to-test Run tests labels Mar 7, 2024
Copy link
Contributor

@carlosmmatos carlosmmatos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@carlosmmatos carlosmmatos merged commit f3975ea into CrowdStrike:main Mar 8, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation ok-to-test Run tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants