[ BUG ] Parameter abstraction handling impacting calls that use arguments instead of keywords

[cah-sean-whalen]

Describe the bug
Calling Hosts.GetDeviceDetails(agent_id) in falconpy 0.5.5 results in an exception.

Introduced in commit ec4d3a5#diff-82ae497787008b6c4bc2b8015761bd7bbcf9853942bf1a43a85cf776a7213673

  File "falconpy\_util.py", line 144, in factory
    return func(*args, **kwargs)
TypeError: GetDeviceDetails() got multiple values for argument 'parameters'

Environment (please complete the following information):

• OS: Windows
• Python 3.9
• FalconPy: 0.5.4 - 0.5.6

[jshcodes]

HI @cah-sean-whalen -

Can you post a sample of the code you were executing so we can recreate this to debug?

[cah-sean-whalen]

@jshcodes Here you go

from falconpy import hosts as FalconHosts

credentials = {
            'client_id': client_id,
            'client_secret': client_secret,
            'base_url': 'https://api.crowdstrike.com'
        }

agent_id = "aidgoeshere"

hosts = FalconHosts.Hosts(creds=credentials)

host_details = hosts.GetDeviceDetails(agent_id)'body']['resources'][0]

[jshcodes]

Ok I've recreated this, and can confirm. To resolve please update your code to the following:

Use keywords instead of arguments

from falconpy import hosts as FalconHosts

credentials = {
            'client_id': client_id,
            'client_secret': client_secret,
            'base_url': 'https://api.crowdstrike.com'   # Don't have to specify this for US-1
        }

agent_id = "aidgoeshere"

hosts = FalconHosts.Hosts(creds=credentials)

host_details = hosts.GetDeviceDetails(ids=agent_id)['body']['resources'][0]

This is being caused by the updated parameter abstraction, which is looping through all of your keywords trying to create the parameters payload. Since we didn't have a keyword in your sample, and we've not coded in an "assume arg 0", it's crashing as it has set the parameter dictionary default twice.

Looking into this now, in the interim, please make sure to specify keywords for calls that dynamically specify parameter dictionary payloads. I've confirmed this issue impacts v0.5.6 as well.

Thank you for the report! 😄