Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated sample to use python dict get() method to avoid KeyNotFound e… #338

Merged
merged 1 commit into from
Sep 15, 2021

Conversation

woodtechie1428
Copy link
Contributor

@woodtechie1428 woodtechie1428 commented Sep 15, 2021

This update resolves an issue within the sensor_versions_by_hostname sample.

  • Bug fixes

Issues resolved

  • Bug fix: updated to use python dict get() method to return None instead of a KeyNotFound exception

…xception

Is this a breaking change?
- No
Are all new or changed code paths covered by unit testing?
- n/a
A complete listing of issues addressed or closed with this change.
- updated to use python dict `get()` method to return None instead of a KeyNotFound exception
A complete listing of any enhancements provided by this change.
- n/a
Any usage details developers may need to make use of this new functionality.
- no
Does additional documentation need to be developed beyond what is listed in your Pull Request?
- no
Any other salient points of interest.
Copy link
Member

@jshcodes jshcodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent call. Thank you for submitting a fix! 😄

@jshcodes jshcodes added code samples Functioning sample code to get you started hosts Hosts or Host Groups issues and questions labels Sep 15, 2021
@jshcodes jshcodes merged commit 90f7306 into CrowdStrike:main Sep 15, 2021
@woodtechie1428 woodtechie1428 deleted the patch-1 branch September 15, 2021 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code samples Functioning sample code to get you started hosts Hosts or Host Groups issues and questions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants