Update github release runner to include macos arm64 #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abrightwell
force-pushed
the
abrightwell/update-release-macos-arm64
branch
3 times, most recently
from
ffe354c to
9c6ac27
Compare
Previously, the github `macos-latest` runner was still an amd64/x86_64 architecture. As such we were not able to have a purely Apple Silicon build through the github release workflow. However, such a runner now exists that supports Apple Silicon[1][2]. However, the `-latest` tag still points to the older images until sometime in Q2 2024[3]. So, we're updating our workflows to be explicit in the `macos-<version>` to ensure the correct architecture is utilized going forward. Also, we are creating a create a specific build target to support Apple Silicon builds using the `macos-14` runner in `.github/workflows/release.yml` as well as updating the `build_macos_amd64` target to use the `macos-13` runner. This will add an extra artifact to the releases which should allow for an easier and perhaps more seamless homebrew release process. [1] https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners/about-github-hosted-runners#standard-github-hosted-runners-for-public-repositories [2] https://github.com/actions/runner-images#available-images [3] https://github.blog/changelog/2024-01-30-github-actions-macos-14-sonoma-is-now-available/
Some of the github actions were deprecated, therefore we're simply updating those to the latest versions in both `ci.yml` and `release.yml`.
abrightwell
force-pushed
the
abrightwell/update-release-macos-arm64
branch
from
9c6ac27 to
fad110c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the github
macos-latestrunner was still an amd64/x86_64 architecture. As such we were not able to have a purely Apple Silicon build through the github release workflow. However, themacos-latestrunner is now supported by Apple Silicon[1]. As such we need to create a specific build target for it in.github/workflows/release.ymlas well as update thebuild_macos_amd64target to use themacos-13runner such that that architecture is still being built.This will add an extra artifact to the releases which should allow for an easier and perhaps more seamless homebrew release process.
[1] https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners/about-github-hosted-runners#standard-github-hosted-runners-for-public-repositories