Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added XUnmountMU and MU_Init #137

Merged
merged 2 commits into from
Jun 15, 2021
Merged

Conversation

ergo720
Copy link
Member

@ergo720 ergo720 commented Jun 14, 2021

This function is necessary to emulate memory units in Cxbx-Reloaded.
I only checked with XDK 3944 and 4831, so testing with other versions would be appreciated.

EDIT: this now also adds MU_Init, which is necessary to derive the memory unit device type. It was tested with xdk versions 3911, 4627, 4831 and 5849.

@github-actions github-actions bot added needs-verification Require verification before approval OOVPA Any OOVPA change relative XAPI OOVPA relative topic labels Jun 14, 2021
@ergo720 ergo720 changed the title Added XUnmountMU Added XUnmountMU and MU_Init Jun 14, 2021
@github-actions github-actions bot added the D3D8LTCG OOVPA relative topic label Jun 14, 2021
@github-actions github-actions bot removed the D3D8LTCG OOVPA relative topic label Jun 14, 2021
Copy link
Member

@RadWolfie RadWolfie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had not check the signatures for any weakness yet nor verify against titles with different xdk build has XMountMUA detected.

src/OOVPADatabase/Xapi_OOVPA.inl Outdated Show resolved Hide resolved
src/OOVPADatabase/Xapi_OOVPA.inl Show resolved Hide resolved
@RadWolfie

This comment has been minimized.

src/OOVPADatabase/Xapi/3911.inl Outdated Show resolved Hide resolved
src/OOVPADatabase/Xapi/4242.inl Outdated Show resolved Hide resolved
@RadWolfie RadWolfie merged commit 9a411fe into Cxbx-Reloaded:master Jun 15, 2021
@RadWolfie RadWolfie removed the needs-verification Require verification before approval label Jun 16, 2021
@ergo720 ergo720 deleted the xunmount branch June 16, 2021 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OOVPA Any OOVPA change relative XAPI OOVPA relative topic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants