Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added XInputSetLightgunCalibration #152

Merged
merged 1 commit into from
Nov 8, 2021

Conversation

ergo720
Copy link
Member

@ergo720 ergo720 commented Nov 7, 2021

Closes #136. I found this function in the games House of the dead 3 (xbox version) and Starsky & Hutch in the "LIGHTGUN" library with xdk version 4831 and 5344 respectively, The OOVPA is able to detect both xdk versions, but I don't know if it will work with older and newer xdks since I don't have other test games for those.

@github-actions github-actions bot added needs-verification Require verification before approval OOVPA Any OOVPA change relative XAPI OOVPA relative topic labels Nov 7, 2021
Copy link
Member

@RadWolfie RadWolfie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two review remarks and a rebase request.

Then everything looks good to me.

src/OOVPADatabase/Xapi/4831.inl Outdated Show resolved Hide resolved
src/OOVPADatabase/Xapi/4831.inl Show resolved Hide resolved
@RadWolfie RadWolfie merged commit 02353e8 into Cxbx-Reloaded:master Nov 8, 2021
@RadWolfie RadWolfie removed the needs-verification Require verification before approval label Nov 8, 2021
@ergo720 ergo720 deleted the lightgun branch November 9, 2021 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OOVPA Any OOVPA change relative XAPI OOVPA relative topic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

XInputSetLightgunCalibration is missing
2 participants