Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix breakage when utf8 string was used in C++20's filesystem on Windows #173

Merged
merged 1 commit into from
Dec 12, 2022

Conversation

RadWolfie
Copy link
Member

Issue was found when testing with "NASCAR® Heat 2002" title. Originally will report as file not found on Windows but that is a bug. After attempt to correct the problem by use Windows' SetConsole(Output)CP functions. Cache file was not output properly due to C++20's filesystem's string are being treat as ansi string on Windows as well. Using u8string cast will make conversion to native string correctly.

@ergo720 ergo720 merged commit f616509 into Cxbx-Reloaded:master Dec 12, 2022
@RadWolfie RadWolfie deleted the fix-utf8-stuff branch December 12, 2022 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants