D3D8LTCG symbols fixes after include .text section filter #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated: - 4034, 5455 - 1024 (aka 5455)
Updated: - 3911 Removed: - 1024
Removed: - D3DDevice_LazySetStateVB (5028, 5558) - CDevice_SetStateVB (4134) Updated: - CDevice_SetStateVB (3911, 4034) Added: - CDevice_SetStateVB_8 (3911, 4039)
Removed: - 4627, 5028 Updated: - 3911, 4034, 1024, 1036
Renamed: - 1024 to 1036 Updated: - 3911, 4034 - 1036, 1048 Added: - 1024 ------ Unused signatures removed: - 4134, 4361, 4627
Updated: - 3911, 4039 - 1024, 1036, 1048
Renamed: - D3DCubeTexture_GetCubeMapSurface2 to D3DCubeTexture_GetCubeMapSurface (1024) Updated: - 3911, 4627 - D3DCubeTexture_GetCubeMapSurface (1024) Added: - D3DCubeTexture_GetCubeMapSurface2 (1024)
Updated: - 3911, 4627, 1024, 1036
Renamed: - D3DDevice_SetTile_0 (2024) to D3DDevice_SetTile_0__LTCG_eax1_ecx2 (3911) - D3DDevice_SetTile_0 (2036) to D3DDevice_SetTile_0__LTCG_ecx1_eax2 (4432) - D3DDevice_SetTile_0 (2048) to D3D_SetTileNoWait_0__LTCG_ecx1_eax2 (4721) - D3DDevice_SetTile_0 (2060) to D3D_SetTileNoWait_0__LTCG_eax1_ecx2 (5455) - D3DDevice_SetTile_0 (2072) to D3D_SetTileNoWait_0__LTCG_ecx1_eax2 (5849) Updated: - D3DDevice_SetTile (3911, 4034) - D3D_SetTileNoWait (4627, 5455) - D3DDevice_SetTile_0__LTCG_eax1_ecx2 (3911) - D3DDevice_SetTile_0__LTCG_ecx1_eax2 (4432, 4721, 5849) - D3D_SetTileNoWait_0__LTCG_eax1_ecx2 (5455) Added: - D3DDevice_SetTile_0__LTCG_ebx1_eax2 (4039) - D3D_SetTileNoWait_0__LTCG_eax1_ecx2 (2024, 2048, 5659)
github-actions
bot
added
D3D8
…PLETE) Added: - D3DDevice_SetTextureStageStateNotInline (3911, 4034) - D3DDevice_SetTextureStageStateNotInline_0__LTCG_ecx1_edx2_eax3 (3911) - D3DDevice_SetTextureStageStateNotInline_0__LTCG_eax1_edx2_ecx3 (4039) - D3DDevice_SetTextureStageStateNotInline2_0__LTCG_eax1_edx2_ecx3 (4039) - D3D_CDevice_SetTextureStageStateNotInline_0__LTCG_eax1_edx2_ecx3 (4039) - D3DDevice_SetTextureStageStateNotInline_0__LTCG_ecx1_eax2_edx3 (4432) - D3DDevice_SetTextureStageStateNotInline_0__LTCG_eax1_edx2_esi3 (4531)
RadWolfie
force-pushed
the
d3dltcg-fixes
branch
from
972a111 to
34720d7
Compare
This was referenced Feb 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When include .text section to the filter for D3D8LTCG titles, numerous of redundant warnings for symbols detected along with weak signatures aren't detecting correct symbol.
All updated signatures except for D3DDevice_SetTextureStageStateNotInline symbol are completed. D3DDevice_SetTextureStageStateNotInline symbol currently have side effect for redundant symbol detected. However, identification of the function indeed look accurate but needs improvement to tell the difference for which one is and isn't extended function which may have absorb into another function. Or has a return. I recommended to ignore D3DDevice_SetTextureStageStateNotInline's commit as it is an improvement but incomplete. I will create a ticket for this incomplete detection.