Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JVS: add g_pPINS(A|B) variables support #188

Merged
merged 4 commits into from
Feb 24, 2023

Conversation

RadWolfie
Copy link
Member

@RadWolfie RadWolfie commented Feb 22, 2023

I made some minor fixes to the scan process that were found during analysis process.

  • Fixed DeviceTypeInfoTable's list may can contain null pointer and extreme size. Most likely caused by XDK build bug but shouldn't break the hardware though.
  • Fixed retain highest build version regardless of unknown library included.
  • Fixed missing JVS' Library<->String conversion functions.

Finally, after a hefty review according to final #75 task. I discovered JVS_g_pPINSA and JVS_g_pPINSB variables can be migrate into our existing signatures to obtain derived addresses. I had to make additional signature for JVS_SendCommand3 since there are two different revisions of it. With this pull request, there is no need for manual scan.

@github-actions github-actions bot added JVS OOVPA relative topic needs-verification Require verification before approval OOVPA Any OOVPA change relative labels Feb 22, 2023
@LukeUsher LukeUsher merged commit f41bb83 into Cxbx-Reloaded:master Feb 24, 2023
@RadWolfie RadWolfie removed the needs-verification Require verification before approval label Feb 24, 2023
@RadWolfie RadWolfie deleted the jvs-add-pins-vars branch February 24, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JVS OOVPA relative topic OOVPA Any OOVPA change relative
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants