JVS: add g_pPINS(A|B) variables support #188
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made some minor fixes to the scan process that were found during analysis process.
Finally, after a hefty review according to final #75 task. I discovered JVS_g_pPINSA and JVS_g_pPINSB variables can be migrate into our existing signatures to obtain derived addresses. I had to make additional signature for JVS_SendCommand3 since there are two different revisions of it. With this pull request, there is no need for manual scan.