Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalize Cleanup for D3D8LTCG errors from Unit Test tool #189

Merged
merged 7 commits into from
Feb 27, 2023

Conversation

RadWolfie
Copy link
Member

Some commits are mostly relative to unit test tool's fatal errors tends to remain open due some symbols were incorrectly named for earlier builds. Plus with some updates to relative cross reference symbols. With one exception of D3DDevice_Reset_0__LTCG_ebx1 addition commit is to enable display mode option change real time from official xbox dashboard support.

@github-actions github-actions bot added D3D8 OOVPA relative topic D3D8LTCG OOVPA relative topic needs-verification Require verification before approval OOVPA Any OOVPA change relative labels Feb 25, 2023
@RadWolfie RadWolfie marked this pull request as draft February 25, 2023 22:51
@RadWolfie
Copy link
Member Author

RadWolfie commented Feb 25, 2023

Turns out I forgot to fully develop D3DDevice_SelectVertexShader_0__LTCG_eax1_ebx2 signatures. I changed PR to draft for now.

EDIT: Resolved

@RadWolfie RadWolfie marked this pull request as ready for review February 26, 2023 13:29
d3dltcg: add D3D_CommonSetMultiSampleModeAndScale_4__LTCG_eax1 sig (5344)
…exture

Renamed:
- D3DDevice_CreateTexture2 (1036) to D3D_CreateTexture_28__LTCG_edx8_edi9 (4039)

Added:
- D3D_CreateTexture (3911, 4034)
- D3DDevice_CreateTexture_8__LTCG_edx3_ecx4_eax5_edi7 (4039)

Plus rearrange D3DDevice_CreateTexture(2) scan priority and temporary fix number order
Added:
- D3DDevice_CreateCubeTexture (4432)
- D3DDevice_CreateCubeTexture_4__LTCG_eax1_edx3_ecx4_edi6 (4039)
- D3DDevice_CreateVolumeTexture_12__LTCG_edx4_ecx5_eax6_edi8 (4039)
- D3DCubeTexture_GetCubeMapSurface(2)
- D3DDevice_GetRenderTarget(2)
Renamed:
- D3DDevice_SelectVertexShader_4 to D3DDevice_SelectVertexShader_4__LTCG_eax1

Added:
- 4039
@RadWolfie RadWolfie merged commit 313ed04 into Cxbx-Reloaded:master Feb 27, 2023
@RadWolfie RadWolfie deleted the d3d-updates branch February 27, 2023 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
D3D8LTCG OOVPA relative topic D3D8 OOVPA relative topic needs-verification Require verification before approval OOVPA Any OOVPA change relative
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant