Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update xxhash submodule to v0.8.2 and one commit ahead for necessary cmake error fix #200

Merged
merged 1 commit into from
Oct 22, 2023

Conversation

RadWolfie
Copy link
Member

@RadWolfie RadWolfie commented Oct 22, 2023

According to recent active pull request's log. CMake expected minimal required to be 3.5 or above from external library used for unit test tool.

CMake Deprecation Error at build/projects/UnitTest/xxhash-src/cmake_unofficial/CMakeLists.txt:8 (cmake_minimum_required):
Compatibility with CMake < 3.5 will be removed from a future version of CMake.

Since upstream already include a fix for this. I proceed with update xxhash submodule to v0.8.2 plus one merged pull request commit relative to cmake fix warning deprecation (which is being treated as error by -Werror=dev flag).

@github-actions github-actions bot added the CMAKE label Oct 22, 2023
@RadWolfie RadWolfie merged commit 3896aab into Cxbx-Reloaded:master Oct 22, 2023
@RadWolfie RadWolfie deleted the update-xxhash branch October 22, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants