Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bulk misc updates #206

Merged
merged 4 commits into from
May 4, 2024
Merged

Bulk misc updates #206

merged 4 commits into from
May 4, 2024

Conversation

RadWolfie
Copy link
Member

Due to GitHub Actions made some regression along with latest macOS's architecture change. I have determined to have all the fixes in one pull request to ensure the GitHub Actions upgrade directly are working with new requirement changes.

GitHub Actions upgrade:

  • actions/checkout@v4
  • actions/upload-artifact@v4
  • actions/download-artifact@v4
  • actions/labeler@v5

The github-script action is added due to workflow's matrix doesn't really accept dynamic selection for specific builder. Although, it does seem a little bloated but does the job simpler.

The previous upload method no longer works with upload-artifact v4. Which require additional job to merge all the upload artifacts into one after the matrix builders are done.

macOS latest (macos-14) made a change from x64 to amd64 architecture. Which require to force fix folder name and add support for amd64.

Finally, labeler action has major rehaul on configuration file layout which require correction before upstream.

@github-actions github-actions bot added OOVPA Any OOVPA change relative needs-verification Require verification before approval CMAKE labels May 2, 2024
@RadWolfie RadWolfie removed the needs-verification Require verification before approval label May 2, 2024
@RadWolfie RadWolfie merged commit 4e459f5 into Cxbx-Reloaded:master May 4, 2024
14 checks passed
@RadWolfie RadWolfie deleted the misc-updates branch May 4, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMAKE OOVPA Any OOVPA change relative
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant