Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check feasibility of sampled discrete parameters in CMAwM #140

Merged
merged 4 commits into from
Dec 27, 2022
Merged

Check feasibility of sampled discrete parameters in CMAwM #140

merged 4 commits into from
Dec 27, 2022

Conversation

knshnb
Copy link
Contributor

@knshnb knshnb commented Dec 27, 2022

Check the feasibility of all parameters instead of only continuous ones.
ref: #136

c-bata
c-bata reviewed Dec 27, 2022
View reviewed changes
Copy link
Collaborator

@c-bata c-bata left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self._continuous_idx and self._continuosu_space looks no longer needed. Could you remove them?

@knshnb
Copy link
Contributor Author

knshnb commented Dec 27, 2022

Good catch! I applied your comment.

c-bata
c-bata approved these changes Dec 27, 2022
View reviewed changes
Copy link
Collaborator

@c-bata c-bata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@c-bata c-bata merged commit 919e4dd into CyberAgentAILab:main Dec 27, 2022
@knshnb knshnb mentioned this pull request Jan 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c-bata c-bata c-bata approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@knshnb @c-bata