fix(ingest): fix log line interpolation (datahub-project#6349)

CybercentreCanada · Nov 18, 2022 · 65ea278 · 65ea278
1 parent ce3a822
commit 65ea278
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/metadata-ingestion/src/datahub/ingestion/run/pipeline.py b/metadata-ingestion/src/datahub/ingestion/run/pipeline.py
@@ -353,7 +353,7 @@ def run(self) -> None:
                     if self._time_to_print():
                         self.pretty_print_summary(currently_running=True)
                 except Exception as e:
-                    logger.warning("Failed to print summary", e)
+                    logger.warning(f"Failed to print summary {e}")
 
                 if not self.dry_run:
                     self.sink.handle_work_unit_start(wu)
@@ -368,7 +368,9 @@ def run(self) -> None:
                 except SystemExit:
                     raise
                 except Exception as e:
-                    logger.error("Failed to process some records. Continuing.", e)
+                    logger.error(
+                        "Failed to process some records. Continuing.", exc_info=e
+                    )
 
                 self.extractor.close()
                 if not self.dry_run:
@@ -393,7 +395,7 @@ def run(self) -> None:
             self.final_status = "completed"
         except (SystemExit, RuntimeError) as e:
             self.final_status = "cancelled"
-            logger.error("Caught error", e)
+            logger.error("Caught error", exc_info=e)
             raise
         finally:
             if callback and hasattr(callback, "close"):