Skip to content

Commit

Permalink
build(ingest): pin mypy version (datahub-project#6391)
Browse files Browse the repository at this point in the history
  • Loading branch information
hsheth2 authored and cccs-Dustin committed Feb 1, 2023
1 parent f3c363b commit 6c8847d
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
1 change: 1 addition & 0 deletions metadata-ingestion/setup.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ plugins =
pydantic.mypy
exclude = ^(venv|build|dist)/
ignore_missing_imports = yes
namespace_packages = no
strict_optional = yes
check_untyped_defs = yes
disallow_incomplete_defs = yes
Expand Down
5 changes: 4 additions & 1 deletion metadata-ingestion/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -373,7 +373,10 @@ def get_long_description():
"flake8>=3.8.3",
"flake8-tidy-imports>=4.3.0",
"isort>=5.7.0",
"mypy>=0.981",
# mypy 0.990 enables namespace packages by default and sets
# no implicit optional to True.
# FIXME: Enable mypy 0.990 when our codebase is fixed.
"mypy>=0.981,<0.990",
# pydantic 1.8.2 is incompatible with mypy 0.910.
# See https://github.com/samuelcolvin/pydantic/pull/3175#issuecomment-995382910.
# Restricting top version to <1.10 until we can fix our types.
Expand Down

0 comments on commit 6c8847d

Please sign in to comment.