Do not execute uv sync for every python project. Fixes #1532

Signed-off-by: Prabhu Subramanian <[email protected]>
CycloneDX · Jan 6, 2025 · 5de8589 · 5de8589
1 parent 90bd2fc
commit 5de8589
Show file tree

Hide file tree

Showing 4 changed files with 22 additions and 11 deletions.
diff --git a/.github/workflows/snapshot-tests.yml b/.github/workflows/snapshot-tests.yml
@@ -55,6 +55,7 @@ jobs:
       - name: Run scripts
         env:
           PREFER_MAVEN_DEPS_TREE: false
+          ATOM_JAVA_HOME: /usr/lib/jvm/java-21-openjdk-amd64
         run: |
           bash new_snapshots/cdxgen_commands.sh
 

diff --git a/lib/cli/index.js b/lib/cli/index.js
@@ -3013,16 +3013,7 @@ export async function createPythonBom(path, options) {
       delete parentComponent.repository;
     }
     // Is this a uv project without a lock file?
-    if (
-      options.installDeps &&
-      (pyProjMap.uvMode ||
-        isPackageManagerAllowed(
-          "uv",
-          ["pip", "poetry", "hatch", "pdm"],
-          options,
-        )) &&
-      !uvLockFiles.length
-    ) {
+    if (options.installDeps && pyProjMap.uvMode && !uvLockFiles.length) {
       createUVLock(path, options);
       uvLockFiles = getAllFiles(
         path,

diff --git a/lib/helpers/utils.test.js b/lib/helpers/utils.test.js
@@ -17,6 +17,7 @@ import {
   getRepoLicense,
   guessPypiMatchingVersion,
   hasAnyProjectType,
+  isPackageManagerAllowed,
   isPartialTree,
   isValidIriReference,
   mapConanPkgRefToPurlStringAndNameAndVersion,
@@ -5732,3 +5733,21 @@ test("hasAnyProjectType tests", () => {
     ),
   ).toBeFalsy();
 });
+
+test("isPackageManagerAllowed tests", () => {
+  expect(
+    isPackageManagerAllowed("uv", ["pip", "poetry", "hatch", "pdm"], {
+      projectType: undefined,
+    }),
+  ).toBeTruthy();
+  expect(
+    isPackageManagerAllowed("uv", ["pip", "poetry", "hatch", "pdm"], {
+      projectType: ["python"],
+    }),
+  ).toBeTruthy();
+  expect(
+    isPackageManagerAllowed("uv", ["pip", "poetry", "hatch", "pdm"], {
+      projectType: ["pip"],
+    }),
+  ).toBeFalsy();
+});
diff --git a/types/lib/cli/index.d.ts.map b/types/lib/cli/index.d.ts.map