Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: install setuptools and wheel before installing requirements #1588

Closed
wants to merge 2 commits into from
Closed

fix: install setuptools and wheel before installing requirements #1588

wants to merge 2 commits into from

Conversation

AnsahMohammad
Copy link
Contributor

Fix the issue #1531
By installing setuptools and wheel before installing requirements.txt

@AnsahMohammad AnsahMohammad requested a review from prabhu as a code owner January 22, 2025 07:27
@prabhu
Copy link
Collaborator

prabhu commented Jan 22, 2025

Can you sign the commit by following this instructions? https://github.com/CycloneDX/cdxgen/pull/1588/checks?check_run_id=35978347400

@prabhu
Copy link
Collaborator

prabhu commented Jan 22, 2025

This is a great start! #1531 is also about making cdxgen programmatically do this. Is this something you can take on?

@AnsahMohammad
Copy link
Contributor Author

Sure i can take that up, how do you want that to be automated?

should that be done using prefetch as you mentioned?

@prabhu
Copy link
Collaborator

prabhu commented Jan 22, 2025

Yes, better if it is done in pregen. Might be an involved task though.

@prabhu
Copy link
Collaborator

prabhu commented Jan 23, 2025

This PR can be merged. Could you sign the commit when you get a moment? https://github.com/CycloneDX/cdxgen/pull/1588/checks?check_run_id=35978347400

@AnsahMohammad
Copy link
Contributor Author

Yes, better if it is done in pregen. Might be an involved task though.

Okay, will that be another PR then ?

@AnsahMohammad
Copy link
Contributor Author

The branch got ugly while trying to rebase, i'll make a new PR (#1594 ) and close this.

asztalosdani added a commit to asztalosdani/cdxgen that referenced this pull request Jan 24, 2025
@asztalosdani
Fix version parsing in CMakeLists files CycloneDX#1588
2f3e522 
Signed-off-by: Daniel Asztalos <[email protected]>
@AnsahMohammad AnsahMohammad deleted the snapshot_test branch January 25, 2025 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prabhu prabhu Awaiting requested review from prabhu prabhu is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AnsahMohammad @prabhu