Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect (de-) serialization of tools #568

Merged
merged 2 commits into from
Dec 10, 2024
Merged

Fix incorrect (de-) serialization of tools #568

merged 2 commits into from
Dec 10, 2024

Conversation

mr-zepol
Copy link
Contributor

@mr-zepol mr-zepol commented Dec 9, 2024

Fixes #562 and #492

@mr-zepol mr-zepol requested a review from a team as a code owner December 9, 2024 22:30
@mr-zepol mr-zepol removed the request for review from a team December 9, 2024 22:30
Copy link

codacy-production bot commented Dec 9, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.08% 91.30%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (2e3b7af) 6358 4745 74.63%
Head commit (f4cc7f4) 6369 (+11) 4758 (+13) 74.71% (+0.08%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#568) 23 21 91.30%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@mr-zepol mr-zepol requested a review from a team December 9, 2024 22:31
@mr-zepol mr-zepol changed the title Fix Issue 562 Fix Issue 562 and 492 Dec 10, 2024
@VinodAnandan
Copy link

@mr-zepol Thank you very much for the fix PR! @andrew-m-leonard @jgraglia @sschuberth
Could you please help with this PR validation if you’re available? Thank you in advance!

@jgraglia
Copy link
Contributor

Hi, I can confirm that this PR fix my pb with tools duplication. My tests are now ok with this PR.
Thank you !

@andrew-m-leonard
Copy link
Contributor

Is there a "build" of this PR please? as we use the pre-built jars from Maven

@nscuro nscuro added the bug Something isn't working label Dec 10, 2024
@nscuro nscuro changed the title Fix Issue 562 and 492 Fix incorrect (de-) serialization of tools Dec 10, 2024
@nscuro nscuro added this to the 10.0.0 milestone Dec 10, 2024
@nscuro nscuro merged commit c7c3aa9 into master Dec 10, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
5 participants