Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move non-public API into a sub-namespace called _internal #427

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

jkowalleck
Copy link
Member

moved non-public API into a sub-namespace called _internal, so that its reliability is obvious.

@jkowalleck jkowalleck requested a review from a team as a code owner October 27, 2023 14:12
@jkowalleck jkowalleck added the documentation Improvements or additions to documentation label Oct 27, 2023
…, so that its reliability is obvious.

Signed-off-by: Jan Kowalleck <[email protected]>
@jkowalleck jkowalleck force-pushed the refactor/internals-more-obvious branch from bdfdc99 to dd7215f Compare October 27, 2023 14:16
@jkowalleck jkowalleck merged commit 29727fb into master Oct 27, 2023
25 of 26 checks passed
@jkowalleck jkowalleck deleted the refactor/internals-more-obvious branch October 27, 2023 14:18
@codacy-production
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% 100.00% (target: 80.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (e5bcce8) 420 399 95.00%
Head commit (dd7215f) 420 (+0) 399 (+0) 95.00% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#427) 2 2 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant