Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DD-1698 + DD-1699: 1.4-DANS-PATCH-1 video #8

Merged
merged 4 commits into from
Feb 10, 2025

Conversation

jo-pol
Copy link

@jo-pol jo-pol commented Feb 10, 2025

Differences between directories v1.4 and v1.4-DANS-PATCH-1

  • preview.css (max-width/height) DD-1699
  • video.js (subtitles, even in draft) DD-1698
    • When a user received permission for the video but not (asked) for the vtt files, the language tags show up but don´t work
    • inline preview does not count as download, preview on separate page does count as download. This behaviour did not change but I doubt it is correct as the new page still has a download button.
    • user friendly mime type for vtt appears as "unknown" should be something like "Web Video Text Track"
      https://developer.mozilla.org/en-US/docs/Web/API/WebVTT_API

Changes of 3ffeb84 are merged into

default track

  • desired languages: &locale=en from the url has precedence over preferred languages as set in the browser
  • available languages extracted from "baseName.en.vtt", "baseName.de-CH.vtt" or "baseName.vtt", 'de-CH' sorted before 'de'
  • per language first a full match is tried, then the main language
  • when no match is found the vtt without language is used if available
  • when still having no default and only one vtt is provided, that one is used

Test data

Quick test:

scp previewers/v1.4-DANS-PATCH-1/js/video.js [email protected]:/var/www/html/dataverse-previewers-1.4/js/video.js
scp previewers/v1.4-DANS-PATCH-1/js/video.js [email protected]:/var/www/html/dataverse-previewers-1.4/css/previe.css

Official install:

deploy.py -m install-previewers

with the following changes for datastations.yml#L1184

shared_dataverse_previewers_version: '1.4-DANS-PATCH-1'
shared_dataverse_previewers_source_account: 'DANS-KNAW'


zip_url: 'https://github.com/{{ shared_dataverse_previewers_source_account }}/dataverse-previewers/archive/refs/tags/{{ shared_dataverse_previewers_version }}.zip'

@jo-pol jo-pol marked this pull request as draft February 10, 2025 11:19
@jo-pol jo-pol marked this pull request as ready for review February 10, 2025 12:59
@janvanmansum janvanmansum merged commit 79ddba1 into DANS-KNAW:v1.4 Feb 10, 2025
@jo-pol jo-pol deleted the origin-v1.4 branch February 18, 2025 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants