Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Potential ODR violation with nlohmann json #1606

Closed
nmm0 opened this issue Nov 9, 2021 · 0 comments · Fixed by #1630
Closed

Potential ODR violation with nlohmann json #1606

nmm0 opened this issue Nov 9, 2021 · 0 comments · Fixed by #1630
Assignees
@jstrzebonski
Labels
type: bug

Comments

@nmm0
Copy link
Collaborator

nmm0 commented Nov 9, 2021

We bundle the json library leading to potential ODR violations (see #1604 for a similar issue). We may have to patch or #define the namespace used to prevent these issues of an application using vt also uses the same library.
@nmm0 nmm0 added the type: bug label Nov 9, 2021
@lifflander lifflander mentioned this issue Dec 14, 2021
Open
jstrzebonski pushed a commit that referenced this issue Dec 15, 2021
#1606 add script supplementing json lib with vt namespace
86f46fd
jstrzebonski pushed a commit that referenced this issue Dec 15, 2021
#1606 supplement json lib with vt namespace
933ab9a
@jstrzebonski jstrzebonski mentioned this issue Dec 15, 2021
Merged
jstrzebonski pushed a commit that referenced this issue Dec 16, 2021
#1606 add script supplementing json lib with vt namespace
fd5970c
jstrzebonski pushed a commit that referenced this issue Dec 16, 2021
#1606 supplement json lib with vt namespace
458666c
jstrzebonski pushed a commit that referenced this issue Dec 21, 2021
#1606 add script supplementing json lib with vt namespace
04c022e
jstrzebonski pushed a commit that referenced this issue Dec 21, 2021
#1606 supplement json lib with vt namespace
828b7fa
jstrzebonski pushed a commit that referenced this issue Dec 22, 2021
#1606 add script supplementing json lib with vt namespace
76438f5
jstrzebonski pushed a commit that referenced this issue Dec 22, 2021
#1606 supplement json lib with vt namespace
097fe3f
lifflander pushed a commit that referenced this issue Dec 22, 2021
@lifflander
#1606 add script supplementing json lib with vt namespace
a7df18b
lifflander pushed a commit that referenced this issue Dec 22, 2021
@lifflander
#1606 supplement json lib with vt namespace
1033cb2
PhilMiller added a commit that referenced this issue Dec 22, 2021
@PhilMiller
Merge pull request #1630 from DARMA-tasking/1606-vt-namespace-in-json…
686e031 
…-lib

#1606 add vt namespace to json lib
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jstrzebonski jstrzebonski

Labels
type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#1606 add vt namespace to json lib DARMA-tasking/vt
2 participants
@nmm0 @jstrzebonski