Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Division by 0 in LB stats calculations #1628

Closed
PhilMiller opened this issue Dec 15, 2021 · 0 comments · Fixed by #1629
Closed

Division by 0 in LB stats calculations #1628

PhilMiller opened this issue Dec 15, 2021 · 0 comments · Fixed by #1629
Assignees

Comments

@PhilMiller
Copy link
Member

PhilMiller commented Dec 15, 2021

Describe the bug

The variance and imbalance metric calculations are prone to division by zero in the case of null contributions.

This became apparent in EMPIRE testing. It's not clear why vt's tests didn't surface this.

To Reproduce
Steps to reproduce the behavior:

  1. Example/test/snippet of code that fails
  2. Compiler, platform, libraries
  3. Run command: number of processors, threading options, etc.
  4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Platform (please complete the following information):

  • Supercomputer or desktop [e.g., Trinity, Sierra)
  • Compiler environment [e.g., clang-3.9, gcc8]
  • Libraries [e.g., mpich-2, openmpi)
  • Commit ID or release of VT [e.g., vt-1.0.0]

Additional context
Add any other context about the problem here.

@PhilMiller PhilMiller self-assigned this Dec 15, 2021
PhilMiller added a commit that referenced this issue Dec 15, 2021
PhilMiller added a commit that referenced this issue Dec 15, 2021
PhilMiller added a commit that referenced this issue Dec 15, 2021
PhilMiller added a commit that referenced this issue Dec 15, 2021
#1628: Fix division by zero in LB stats
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant