Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make CollectionContextHolder::set take and store const IndexT #1747

Closed
PhilMiller opened this issue Apr 26, 2022 · 0 comments · Fixed by #1750
Closed

Make CollectionContextHolder::set take and store const IndexT #1747

PhilMiller opened this issue Apr 26, 2022 · 0 comments · Fixed by #1750
Assignees
@stmcgovern
Labels
type: task

Comments

@PhilMiller
Copy link
Member

The function signature static void set(IndexT* const set_idx, VirtualProxyType const& set_proxy) puts the const in the not-so-helpful place, denoting a constant pointer, not a pointer to a constant value. The holder should be promising not to modify the thing to which it's been given a pointer
@stmcgovern stmcgovern self-assigned this Apr 26, 2022
stmcgovern added a commit that referenced this issue Apr 27, 2022
@stmcgovern
#1747: change const pointer to pointer to const IndexT
4c579a6
@stmcgovern stmcgovern mentioned this issue Apr 27, 2022
Merged
@stmcgovern stmcgovern linked a pull request Apr 27, 2022 that will close this issue
#1747: change const pointer to pointer to const IndexT #1750
Merged
stmcgovern added a commit that referenced this issue Apr 27, 2022
@stmcgovern
#1747: change const pointer to pointer to const IndexT
80ad4f7
stmcgovern added a commit that referenced this issue Apr 27, 2022
@stmcgovern
#1747: follow style guidelines
01e0085
stmcgovern added a commit that referenced this issue Apr 27, 2022
@stmcgovern
#1747: follow style guidelines
1c5d636
stmcgovern added a commit that referenced this issue Apr 28, 2022
@stmcgovern
#1747: change const pointer to pointer to const IndexT
06c0276
stmcgovern added a commit that referenced this issue Apr 28, 2022
@stmcgovern
#1747: follow style guidelines
9e2e01c
lifflander added a commit that referenced this issue Apr 28, 2022
@lifflander
Merge pull request #1750 from DARMA-tasking/1747-make-collectionconte…
cee9fe4 
…xtholderset-take-and-store-const-indext

#1747: change const pointer to pointer to const IndexT
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stmcgovern stmcgovern

Labels
type: task
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#1747: change const pointer to pointer to const IndexT DARMA-tasking/vt
2 participants
@PhilMiller @stmcgovern