Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix subphases handling in getModeledComm #1835

Closed
cz4rs opened this issue Jun 1, 2022 · 0 comments · Fixed by #1842
Closed

fix subphases handling in getModeledComm #1835

cz4rs opened this issue Jun 1, 2022 · 0 comments · Fixed by #1842
Assignees

Comments

@cz4rs
Copy link
Contributor

cz4rs commented Jun 1, 2022

Describe the bug
Currently RawData::getModeledComm does not consider subphases (note: this method might get moved out of RawData model). Fix that by handling them the same way CommOverhead does.


if (offset.subphase == PhaseOffset::WHOLE_PHASE) {
return work + overhead;
} else {
// @todo: we don't record comm costs for each subphase---split it proportionally
auto whole_phase_work = ComposedModel::getWork(object, PhaseOffset{offset.phases, PhaseOffset::WHOLE_PHASE});
return work + overhead * ( static_cast<double>(work)/whole_phase_work );
}

(notice the old todo here as well)

Originally posted by @cz4rs in #1695 (comment)

@cz4rs cz4rs self-assigned this Jun 1, 2022
cz4rs added a commit that referenced this issue Jun 6, 2022
cz4rs added a commit that referenced this issue Jun 6, 2022
cz4rs added a commit that referenced this issue Jun 8, 2022
cz4rs added a commit that referenced this issue Jun 8, 2022
cz4rs added a commit that referenced this issue Jun 8, 2022
cz4rs added a commit that referenced this issue Jun 8, 2022
cz4rs added a commit that referenced this issue Jun 8, 2022
cz4rs added a commit that referenced this issue Jun 8, 2022
cz4rs added a commit that referenced this issue Jun 8, 2022
cz4rs added a commit that referenced this issue Jun 8, 2022
cz4rs added a commit that referenced this issue Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant