Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicate symbols on some Mac builds #2062

Closed
nlslatt opened this issue Jan 13, 2023 · 0 comments · Fixed by #2065
Closed

Fix duplicate symbols on some Mac builds #2062

nlslatt opened this issue Jan 13, 2023 · 0 comments · Fixed by #2065
Assignees

Comments

@nlslatt
Copy link
Collaborator

nlslatt commented Jan 13, 2023

Describe the bug
Some vt executables and vt-enabled apps get link errors on Mac:

duplicate symbol 'typeinfo name for vt::pool::MemoryPoolEqual<64ll, true>' in:
    src/libvt-debug.a(memory_pool_equal.cc.o)
    src/libvt-debug.a(runnable.cc.o)
duplicate symbol 'typeinfo for vt::pool::MemoryPoolEqual<64ll, true>' in:
    src/libvt-debug.a(memory_pool_equal.cc.o)
    src/libvt-debug.a(runnable.cc.o)
duplicate symbol 'typeinfo name for vt::pool::MemoryPoolEqual<1024ll, true>' in:
    src/libvt-debug.a(memory_pool_equal.cc.o)
    src/libvt-debug.a(runnable.cc.o)
duplicate symbol 'typeinfo for vt::pool::MemoryPoolEqual<1024ll, true>' in:
    src/libvt-debug.a(memory_pool_equal.cc.o)
    src/libvt-debug.a(runnable.cc.o)

This appears to be related to the #include "src/vt/pool/static_sized/memory_pool_equal.cc" line at the end of src/vt/runnable/runnable.cc. That #include is required, but it seems like the build system is also building memory_pool_equal.cc separately due to the .cc extension, which can result in linking errors. Rename memory_pool_equal.cc so that it doesn't get built separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant