-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Embedded vt as a subdirectory exports ccache
usage to enclosing project
#2144
Comments
@PhilMiller What were you envisioning as a solution here? Make using ccache always opt-in or have differing behavior for embedded in application vs. standalone builds? |
I don't have a particular solution in mind. The simplest approach, I suppose, is to remove the integrated ccache usage, and just let that be something that someone (or some script) building vt specify by the usual CMake means |
thearusable
added a commit
that referenced
this issue
May 26, 2023
thearusable
added a commit
that referenced
this issue
May 30, 2023
thearusable
added a commit
that referenced
this issue
May 31, 2023
thearusable
added a commit
that referenced
this issue
May 31, 2023
thearusable
added a commit
that referenced
this issue
May 31, 2023
thearusable
added a commit
that referenced
this issue
May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
An application that embeds vt and refers to it via
add_subdirectory
finds that it getsccache
picked up automatically, regardless of whether the person building the application wanted it, or whether that application has its own configuration mechanism to choose to useccache
. Vt should definitely not be doing this in the embedded case.Offending CMake code is here:
https://github.com/DARMA-tasking/vt/blob/develop/CMakeLists.txt#L28
This corresponds to DARMA-tasking/magistrate#302
To Reproduce
Steps to reproduce the behavior:
Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Platform (please complete the following information):
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: