Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracing component creates directory when trace is runtime disabled #511

Closed
lifflander opened this issue Oct 23, 2019 · 1 comment
Closed

Tracing component creates directory when trace is runtime disabled #511

lifflander opened this issue Oct 23, 2019 · 1 comment
Assignees
@lifflander
Labels
1.0.0-beta.3 1.0.0 type: bug
Milestone
1.0.0-beta

Comments

@lifflander
Copy link
Collaborator

Describe the bug
theTrace should not so any setup (directory or files) if the runtime flag is off.

To Reproduce
Steps to reproduce the behavior:

  1. Run VT with compile-time tracing enabled and runtime tracing disabled, no directory specified for tracing
@lifflander lifflander self-assigned this Oct 23, 2019
@lifflander lifflander added this to the 1.0.0-beta milestone Oct 23, 2019
lifflander added a commit that referenced this issue Oct 23, 2019
@lifflander
#511: trace: only create trace directory when runtime enabled
ca26b4b
lifflander added a commit that referenced this issue Oct 28, 2019
@lifflander
#511: trace: only create trace directory when runtime enabled
91a7f1e
lifflander added a commit that referenced this issue Oct 28, 2019
@lifflander
#511: trace: only create trace directory when runtime enabled
e0bbba1
@lifflander
Copy link
Collaborator Author

Closing merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lifflander lifflander

Labels
1.0.0-beta.3 1.0.0 type: bug
Projects
None yet
Milestone
1.0.0-beta
Development

No branches or pull requests
1 participant
@lifflander