Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1031 add action to check PR's description format #1058

Merged
merged 1 commit into from
Sep 19, 2020
Merged

1031 add action to check PR's description format #1058

merged 1 commit into from
Sep 19, 2020

Conversation

jstrzebonski
Copy link
Contributor

@jstrzebonski jstrzebonski commented Sep 15, 2020 •
edited
Loading

Fixes #1031

Most of the work is done in DARMA-tasking/check-pr-fixes-issue#1

The action is run every time the PR title or description (PR's first comment) is edited, and after opening and reopening the PR. If you want to play with it by yourself feel free to check this PR -> jstrzebonski/action_test#9 to not litter this PR anymore.

@jstrzebonski jstrzebonski self-assigned this Sep 15, 2020
@jstrzebonski jstrzebonski force-pushed the 1031-commit-check-for-fixes-issue branch 2 times, most recently from 98b7249 to a4e3f75 Compare September 16, 2020 17:28
@jstrzebonski jstrzebonski changed the title #1031 add action to check PR's description format #1031 add action to check PR's description format. Sep 16, 2020
@jstrzebonski jstrzebonski force-pushed the 1031-commit-check-for-fixes-issue branch from a4e3f75 to 4f9c828 Compare September 16, 2020 19:28
@jstrzebonski jstrzebonski changed the title #1031 add action to check PR's description format. #1031 add action to check PR's description format Sep 16, 2020
@jstrzebonski jstrzebonski changed the title #1031 add action to check PR's description format add action to check PR's description format. Sep 16, 2020
@jstrzebonski jstrzebonski changed the title add action to check PR's description format. #1031 add action to check PR's description format Sep 16, 2020
@jstrzebonski jstrzebonski changed the title #1031 add action to check PR's description format #add action to check PR's description format Sep 16, 2020
@jstrzebonski jstrzebonski changed the title #add action to check PR's description format #1031add action to check PR's description format Sep 16, 2020
@jstrzebonski jstrzebonski changed the title #1031add action to check PR's description format #1031 add action to check PR's description format Sep 16, 2020
@jstrzebonski jstrzebonski changed the title #1031 add action to check PR's description format 1031 add action to check PR's description format Sep 16, 2020
@jstrzebonski jstrzebonski marked this pull request as ready for review September 16, 2020 20:20
jstrzebonski
jstrzebonski commented Sep 16, 2020
View reviewed changes
.github/workflows/check-pr-comment-fixes-issue.yml Outdated
name: Check PR description
runs-on: ubuntu-latest
steps:
- uses: DARMA-tasking/check-pr-fixes-issue@1031-commit-check-for-fixes-issue
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will be changed to @master after merging DARMA-tasking/check-pr-fixes-issue#1

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's merged

@jstrzebonski jstrzebonski force-pushed the 1031-commit-check-for-fixes-issue branch 2 times, most recently from f591c60 to 717d46e Compare September 18, 2020 17:15
@jstrzebonski
Copy link
Contributor Author

@lifflander Should this check be Required? If so you'll have to change repo settings (I don't have rights to do it :'- ( ). Plus I'll update wiki/Pull-Requests paragraph.

@lifflander
Copy link
Collaborator

@lifflander Should this check be Required? If so you'll have to change repo settings (I don't have rights to do it :'- ( ). Plus I'll update wiki/Pull-Requests paragraph.

Yes, I will make it required!

@lifflander
Copy link
Collaborator

lifflander commented Sep 18, 2020 •
edited
Loading

Done, it should be required now. I temporarily made it optional until we get this merged so other PRs can be merged.

lifflander
lifflander approved these changes Sep 18, 2020
View reviewed changes
Copy link
Collaborator

@lifflander lifflander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is approved once you switch it to master!

@jstrzebonski jstrzebonski force-pushed the 1031-commit-check-for-fixes-issue branch from 717d46e to bfcde42 Compare September 18, 2020 21:14
@jstrzebonski
Copy link
Contributor Author

jstrzebonski commented Sep 18, 2020 •
edited
Loading

@lifflander Done.

Also I've just updated https://github.com/DARMA-tasking/vt/wiki/Pull-Requests with short description of check-pr-fixes-issue in 3rd point- All required checks must pass

@codecov
Copy link

codecov bot commented Sep 18, 2020

Codecov Report

Merging #1058 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1058   +/-   ##
========================================
  Coverage    77.61%   77.61%           
========================================
  Files          672      672           
  Lines        25771    25771           
========================================
  Hits         20001    20001           
  Misses        5770     5770

@lifflander
Copy link
Collaborator

@lifflander Done.

Also I've just updated https://github.com/DARMA-tasking/vt/wiki/Pull-Requests with short description of check-pr-fixes-issue in 3rd point- All required checks must pass

Thanks for updating it!

@lifflander lifflander merged commit 14b814c into develop Sep 19, 2020
@jstrzebonski jstrzebonski deleted the 1031-commit-check-for-fixes-issue branch November 7, 2020 14:58
@cz4rs cz4rs mentioned this pull request Jun 15, 2021
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lifflander lifflander lifflander approved these changes

@cz4rs cz4rs Awaiting requested review from cz4rs

@JacobDomagala JacobDomagala Awaiting requested review from JacobDomagala

@PhilMiller PhilMiller Awaiting requested review from PhilMiller

@pnstickne pnstickne Awaiting requested review from pnstickne

Assignees

@jstrzebonski jstrzebonski

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add commit check for "Fixes #issue" in comment
2 participants
@jstrzebonski @lifflander