1112 Callback: Add sendMsg() which takes MsgPtrThief #1119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1119 +/- ##
===========================================
- Coverage 75.92% 75.90% -0.02%
===========================================
Files 713 713
Lines 26940 26928 -12
===========================================
- Hits 20453 20441 -12
Misses 6487 6487
|
JacobDomagala
force-pushed
the
1112-add-msgptrthief-for-callbacks
branch
2 times, most recently
from
0fb6789 to
84c5c2d
Compare
JacobDomagala
requested review from
lifflander,
cz4rs,
PhilMiller and
jstrzebonski
PhilMiller
reviewed
Oct 23, 2020
| @@ -128,9 +128,15 @@ struct CallbackRawBaseSingle { | |||
| bool null() const { return cb_.null(); } | |||
| bool valid() const { return cb_.valid(); } | |||
|
|
|||
| template <typename MsgT, typename... Args> | |||
| void send(Args... args); | |||
|
|
|||
| template <typename MsgT> | |||
| void send(MsgT* msg); | |||
There was a problem hiding this comment.
As elsewhere, do we want to mark this overload as deprecated?
There was a problem hiding this comment.
I would assume it's widely used in EMPIRE, not sure if we want to flood it with warnings. We could add doxygen \deprecated command though.
Can you comment on that @lifflander?
PhilMiller
reviewed
Oct 23, 2020
| @@ -232,12 +238,22 @@ struct CallbackTyped : CallbackRawBaseSingle { | |||
| cb_ = std::move(other.cb_); | |||
| } | |||
|
|
|||
| template <typename MsgU, typename... Args> | |||
| void send(Args... args) { | |||
| static_assert(std::is_same<MsgT, MsgU>::value, "Required exact type match"); | |||
There was a problem hiding this comment.
I could see us wanting to loosen this to derivation, or even convertibility. No need to do that here and now, though.
PhilMiller
reviewed
Oct 23, 2020
PhilMiller
approved these changes
Oct 23, 2020
lifflander
reviewed
Oct 23, 2020
| @@ -128,9 +128,15 @@ struct CallbackRawBaseSingle { | |||
| bool null() const { return cb_.null(); } | |||
| bool valid() const { return cb_.valid(); } | |||
|
|
|||
| template <typename MsgT, typename... Args> | |||
There was a problem hiding this comment.
Now that I'm looking at this, is there some way to avoid having to specify MsgT when the type is known by the (e.g, callback Callback<MyMsg>)?
…ts (when applicable)
…gs and using them creates message which should be sent
…y using template param
JacobDomagala
force-pushed
the
1112-add-msgptrthief-for-callbacks
branch
from
84c5c2d to
1f66454
Compare
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1112
Changes: