Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1169: CI: allocate gcc-7 build to new agent pool #1170

Merged
merged 1 commit into from
Dec 1, 2020

Conversation

lifflander
Copy link
Collaborator

Fixes #1169

@lifflander lifflander requested a review from cz4rs November 30, 2020 23:16
@codecov
Copy link

codecov bot commented Dec 1, 2020

Codecov Report

Merging #1170 (5e319e4) into develop (65408f6) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1170      +/-   ##
===========================================
- Coverage    79.58%   79.57%   -0.01%     
===========================================
  Files          723      723              
  Lines        27774    27774              
===========================================
- Hits         22103    22101       -2     
- Misses        5671     5673       +2     
Impacted Files Coverage Δ
src/vt/vrt/collection/balance/stats_msg.h 97.01% <0.00%> (-2.99%) ⬇️

@lifflander lifflander force-pushed the 1169-upgrade-ci-resources-for-failing-builds branch from bd7791f to 4a73e2e Compare December 1, 2020 04:16
Copy link
Contributor

@cz4rs cz4rs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good as long as the gcc-7 passes, please squash the commits / rewrite history a bit

@cz4rs
Copy link
Contributor

cz4rs commented Dec 1, 2020

minor note: the gcc-7 build stage seems pretty slow :/

@lifflander
Copy link
Collaborator Author

minor note: the gcc-7 build stage seems pretty slow :/

Yes, I'm planning on sqashing. I just upgraded that build to 4 cores. Now it runs in 30 mins.

@lifflander lifflander force-pushed the 1169-upgrade-ci-resources-for-failing-builds branch from 7ff757e to bdea1c4 Compare December 1, 2020 20:57
@lifflander
Copy link
Collaborator Author

Once I have the password issue fixed, I will merge this. I have to rebuild the base linux image to fix this with the credentials encrypted in it.

@lifflander lifflander force-pushed the 1169-upgrade-ci-resources-for-failing-builds branch from bdea1c4 to 5e319e4 Compare December 1, 2020 22:32
@lifflander lifflander marked this pull request as ready for review December 1, 2020 22:32
@lifflander lifflander merged commit 609d827 into develop Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants