Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1207 Fix Mac CI #1208

Merged
merged 5 commits into from
Jan 11, 2021
Merged

1207 Fix Mac CI #1208

merged 5 commits into from
Jan 11, 2021

Conversation

lifflander
Copy link
Collaborator

Fixes #1207

@lifflander lifflander requested a review from PhilMiller January 7, 2021 23:33
@codecov
Copy link

codecov bot commented Jan 7, 2021

Codecov Report

Merging #1208 (69bda92) into develop (64c3be4) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1208      +/-   ##
===========================================
- Coverage    81.02%   80.99%   -0.03%     
===========================================
  Files          730      730              
  Lines        28046    28046              
===========================================
- Hits         22723    22717       -6     
- Misses        5323     5329       +6     
Impacted Files Coverage Δ
src/vt/termination/dijkstra-scholten/comm.cc 54.54% <0.00%> (-12.73%) ⬇️
tests/unit/atomic/test_atomic.cc 100.00% <0.00%> (+1.31%) ⬆️

@lifflander lifflander self-assigned this Jan 11, 2021
@lifflander lifflander changed the title 1207 Unlink python2 before installing packages to fix CI 1207 Fix Mac CI Jan 11, 2021
@lifflander
Copy link
Collaborator Author

Turns out that the Mac CI fix is easily than I thought--stop upgrading it before installing the packages.

Copy link
Contributor

@cz4rs cz4rs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@PhilMiller
Copy link
Member

I'm fine with this.

Does Homebrew keep older versions available indefinitely, so that whatever is referenced from the index in the image will install nicely? If not, this is going to break with some regularity and require manual updates. Still better than being continuously broken right now.

@lifflander
Copy link
Collaborator Author

I'm fine with this.

Does Homebrew keep older versions available indefinitely, so that whatever is referenced from the index in the image will install nicely? If not, this is going to break with some regularity and require manual updates. Still better than being continuously broken right now.

Not sure about homebrew... but I don't think they keep old versions on the platform. homebrew comes pre-installed on the image

@lifflander lifflander merged commit c36ad0e into develop Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Mac CI target failure due to brew linking python
3 participants