Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1233: clang builds fail to compile with OpenMP #1241

Merged
merged 1 commit into from
Jan 29, 2021
Merged

1233: clang builds fail to compile with OpenMP #1241

merged 1 commit into from
Jan 29, 2021

Conversation

cz4rs
Copy link
Contributor

@cz4rs cz4rs commented Jan 29, 2021

fixes #1233

@cz4rs
Copy link
Contributor Author

cz4rs commented Jan 29, 2021 •
edited
Loading

verified in local environment, I will enable OpenMP for one of the clang CI builds in #1214

edit: if I understand correctly, this will also require pushing new versions of ubuntu-18.04-clang-cpp.dockerfile and ubuntu-20.04-clang-cpp.dockerfile to dockerhub (?)

@DARMA-tasking DARMA-tasking deleted a comment from azure-pipelines bot Jan 29, 2021
@DARMA-tasking DARMA-tasking deleted a comment from azure-pipelines bot Jan 29, 2021
@DARMA-tasking DARMA-tasking deleted a comment from azure-pipelines bot Jan 29, 2021
@DARMA-tasking DARMA-tasking deleted a comment from azure-pipelines bot Jan 29, 2021
@codecov
Copy link

codecov bot commented Jan 29, 2021

Codecov Report

Merging #1241 (3ac4f92) into develop (468a384) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1241   +/-   ##
========================================
  Coverage    81.01%   81.01%           
========================================
  Files          730      730           
  Lines        28057    28057           
========================================
+ Hits         22729    22730    +1     
+ Misses        5328     5327    -1
Impacted Files Coverage Δ
...vt/vrt/collection/balance/hierarchicallb/hierlb.cc 88.44% <0.00%> (+0.33%) ⬆️

@jstrzebonski
Copy link
Contributor

jstrzebonski commented Jan 29, 2021 •
edited
Loading

Seems to be OK.
I'll wait with approve till new images are uploaded.

@PhilMiller PhilMiller merged commit b9214ca into develop Jan 29, 2021
@cz4rs cz4rs mentioned this pull request Jan 30, 2021
Merged
@cz4rs cz4rs mentioned this pull request Jun 15, 2021
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilMiller PhilMiller PhilMiller approved these changes

@JacobDomagala JacobDomagala JacobDomagala approved these changes

@lifflander lifflander Awaiting requested review from lifflander

@bradybray bradybray Awaiting requested review from bradybray

@jstrzebonski jstrzebonski Awaiting requested review from jstrzebonski

@nlslatt nlslatt Awaiting requested review from nlslatt

@nmm0 nmm0 Awaiting requested review from nmm0

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

clang builds fail to compile with OpenMP
4 participants
@cz4rs @jstrzebonski @PhilMiller @JacobDomagala