1328: Change CMake to also run tests on single node. #1329

JacobDomagala · 2021-03-16T12:10:24Z

Add helper macros to skip tests in runtime based on number of nodes
Change CMake to also run the tests on single rank
Skip the tests that aren't meant to be run on less than 2 nodes

JacobDomagala · 2021-03-16T12:15:33Z

tests/unit/sequencer/test_sequencer_extensive.extended.cc

+  if(isOversubscribed()){
+    return ParamContainerType{};
+  }
+


This one is related to #1306

github-actions · 2021-03-16T12:25:36Z

PR tests (clang-3.9, ubuntu, mpich)

Build for 62e3d1b

Compilation - successful

Testing - passed

Build log

github-actions · 2021-03-16T12:27:54Z

PR tests (gcc-6, ubuntu, mpich)

Build for 62e3d1b

Compilation - successful

Testing - passed

Build log

github-actions · 2021-03-16T12:34:08Z

PR tests (clang-5.0, ubuntu, mpich)

Build for 62e3d1b

Compilation - successful

Testing - passed

Build log

github-actions · 2021-03-16T12:34:12Z

PR tests (gcc-5, ubuntu, mpich)

Build for 62e3d1b

Compilation - successful

Testing - passed

Build log

github-actions · 2021-03-16T12:34:34Z

PR tests (nvidia cuda 11.0, ubuntu, mpich)

Build for 62e3d1b

Compilation - successful

Testing - passed

Build log

github-actions · 2021-03-16T12:37:25Z

PR tests (nvidia cuda 10.1, ubuntu, mpich)

Build for 62e3d1b

Compilation - successful

Testing - passed

Build log

github-actions · 2021-03-16T12:37:54Z

PR tests (clang-8, alpine, mpich)

Build for 62e3d1b

Compilation - successful

Testing - passed

Build log

github-actions · 2021-03-16T12:39:21Z

PR tests (gcc-10, ubuntu, openmpi, no LB)

Build for 62e3d1b

Compilation - successful

Testing - passed

Build log

github-actions · 2021-03-16T12:39:48Z

PR tests (gcc-9, ubuntu, mpich, zoltan)

Build for 62e3d1b

Compilation - successful

Testing - passed

Build log

github-actions · 2021-03-16T12:40:39Z

PR tests (gcc-8, ubuntu, mpich, address sanitizer)

Build for 62e3d1b

Compilation - successful

Testing - passed

Build log

JacobDomagala · 2021-03-16T12:46:01Z

tests/CMakeLists.txt

      )

      set_tests_properties(
        ${${CUR_TEST_LIST}}
        PROPERTIES TIMEOUT 60
        FAIL_REGULAR_EXPRESSION "FAILED;should be deleted but never is;Segmentation fault"
        PASS_REGULAR_EXPRESSION "PASSED"
+        SKIP_REGULAR_EXPRESSION "SKIPPED"


Skipped tests are displayed in the run summary like so:

I will test whether it interferes with our 'comment-pr' action when test fails.

Looks like it doesn't break anything:

github-actions · 2021-03-16T12:50:12Z

PR tests (gcc-7, ubuntu, mpich, trace runtime, LB)

Build for 62e3d1b

Compilation - successful

Testing - passed

Build log

github-actions · 2021-03-16T13:13:36Z

PR tests (intel 19, ubuntu, mpich)

Build for 62e3d1b

Compilation - successful

Testing - passed

Build log

github-actions · 2021-03-16T13:17:30Z

PR tests (intel 18.03, ubuntu, mpich)

Build for 62e3d1b

Compilation - successful

Testing - passed

Build log

tests/unit/main.cc

lifflander

Looks good and ready to me!

JacobDomagala · 2021-03-25T11:03:07Z

After rebasing the branch with the latest changes from develop, some tests started to fail while running on the single node.
I'm looking into that

src/vt/pipe/callback/handler_send/callback_send_tl.impl.h

PhilMiller · 2021-03-30T17:39:26Z

src/vt/pipe/callback/handler_send/callback_send.impl.h

@@ -112,7 +112,7 @@ CallbackSend<MsgT>::triggerDispatch(SignalDataType* data, PipeType const& pid) {
    auto msg = reinterpret_cast<ShortMessage*>(data);
    auto m = promoteMsg(msg);
    runnable::makeRunnable(m, true, handler_, this_node)
-      .withTDEpochFromMsg()
+      .withTDEpoch(theMsg()->getEpoch())


As discussed on today's call, the message should get an epoch set on it, and this code should go back to calling withTDEpochFromMsg()

The same probably applies to the other callback and reduce cases

…s for current machine

…sts based on the current number of nodes/ranks

…hether we run MPI tests or not

…have already been using conditional execution based on num nodes

…d via Get function

… reduceRootRecv

lifflander

Looks good to me. The new changes for callbacks look correct.

JacobDomagala self-assigned this Mar 16, 2021

JacobDomagala commented Mar 16, 2021

View reviewed changes

JacobDomagala mentioned this pull request Mar 16, 2021

1297: Add CMake variable to set max number of ranks/nodes for tests and examples. #1306

Merged

JacobDomagala commented Mar 16, 2021

View reviewed changes

JacobDomagala force-pushed the 1328-run-tests-on-single-node branch 2 times, most recently from 5339d92 to b5bd803 Compare March 16, 2021 13:54

JacobDomagala marked this pull request as ready for review March 16, 2021 16:18

JacobDomagala requested review from lifflander, cz4rs, jstrzebonski, nlslatt, nmm0 and PhilMiller March 16, 2021 16:18

JacobDomagala commented Mar 16, 2021

View reviewed changes

tests/unit/main.cc Outdated Show resolved Hide resolved

JacobDomagala marked this pull request as draft March 17, 2021 20:43

JacobDomagala force-pushed the 1328-run-tests-on-single-node branch 2 times, most recently from 95cd740 to cfe1ff3 Compare March 23, 2021 16:32

JacobDomagala marked this pull request as ready for review March 23, 2021 16:34

lifflander mentioned this pull request Mar 23, 2021

Meeting Agenda [do not close] #925

Open

JacobDomagala changed the title ~~1328: Change CMake to run tests on single node.~~ 1328: Change CMake to also run tests on single node. Mar 24, 2021

lifflander approved these changes Mar 25, 2021

View reviewed changes

JacobDomagala force-pushed the 1328-run-tests-on-single-node branch from cfe1ff3 to 47470a8 Compare March 25, 2021 10:34

JacobDomagala force-pushed the 1328-run-tests-on-single-node branch from 2c0f46e to cf18bb0 Compare March 29, 2021 19:06

JacobDomagala commented Mar 29, 2021

View reviewed changes

src/vt/pipe/callback/handler_send/callback_send_tl.impl.h Outdated Show resolved Hide resolved

PhilMiller mentioned this pull request Mar 30, 2021

Callback needs explicit epoch setting behavior on generated messages #1353

Open

3 tasks

PhilMiller reviewed Mar 30, 2021

View reviewed changes

JacobDomagala force-pushed the 1328-run-tests-on-single-node branch 3 times, most recently from 934d3f8 to 4e48c4a Compare April 2, 2021 14:22

JacobDomagala added 10 commits April 2, 2021 20:14

#1328: cmake: Add CMake variable with maximum detected number of node…

0bf24b4

…s for current machine

#1328: tests: Add helper macros and functions to skip running unit te…

dccfe21

…sts based on the current number of nodes/ranks

#1328: tests: Pass runtime argument to unit tests, which determines w…

097a7ba

…hether we run MPI tests or not

#1328: tests: Store number of ranks in test's MPI singleton

6dc9ab6

#1328: tests: Apply newly added macros to skip the tests wherever we …

b6c530b

…have already been using conditional execution based on num nodes

#1328: tests: Run unittests on single rank

1c5d8bc

#1328: tests: Skip tests that can't run on single node

4d5eac4

#1328: tests: Initialize MPI only once

f1d0f3b

#1328: tests: Make MPI singleton initializie 'on demand' when accesse…

af42d54

…d via Get function

#1328: runnable: Set epoch for Callback messages and before executing…

62e3d1b

… reduceRootRecv

JacobDomagala force-pushed the 1328-run-tests-on-single-node branch from 4e48c4a to 62e3d1b Compare April 2, 2021 18:14

JacobDomagala requested review from lifflander and PhilMiller April 5, 2021 11:32

lifflander approved these changes Apr 5, 2021

View reviewed changes

JacobDomagala merged commit 0542da4 into develop Apr 5, 2021

cz4rs mentioned this pull request Jun 15, 2021

move vt version number into a separate file #1467

Closed

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

1328: Change CMake to also run tests on single node. #1329

1328: Change CMake to also run tests on single node. #1329

JacobDomagala commented Mar 16, 2021

JacobDomagala Mar 16, 2021

github-actions bot commented Mar 16, 2021 •

edited

Loading

github-actions bot commented Mar 16, 2021 •

edited

Loading

github-actions bot commented Mar 16, 2021 •

edited

Loading

github-actions bot commented Mar 16, 2021 •

edited

Loading

github-actions bot commented Mar 16, 2021 •

edited

Loading

github-actions bot commented Mar 16, 2021 •

edited

Loading

github-actions bot commented Mar 16, 2021 •

edited

Loading

github-actions bot commented Mar 16, 2021 •

edited

Loading

github-actions bot commented Mar 16, 2021 •

edited

Loading

github-actions bot commented Mar 16, 2021 •

edited

Loading

JacobDomagala Mar 16, 2021

JacobDomagala Mar 16, 2021

github-actions bot commented Mar 16, 2021 •

edited

Loading

github-actions bot commented Mar 16, 2021 •

edited

Loading

github-actions bot commented Mar 16, 2021 •

edited

Loading

lifflander left a comment

JacobDomagala commented Mar 25, 2021

PhilMiller Mar 30, 2021

lifflander left a comment

1328: Change CMake to also run tests on single node. #1329

1328: Change CMake to also run tests on single node. #1329

Conversation

JacobDomagala commented Mar 16, 2021

JacobDomagala Mar 16, 2021

Choose a reason for hiding this comment

github-actions bot commented Mar 16, 2021 • edited Loading

github-actions bot commented Mar 16, 2021 • edited Loading

github-actions bot commented Mar 16, 2021 • edited Loading

github-actions bot commented Mar 16, 2021 • edited Loading

github-actions bot commented Mar 16, 2021 • edited Loading

github-actions bot commented Mar 16, 2021 • edited Loading

github-actions bot commented Mar 16, 2021 • edited Loading

github-actions bot commented Mar 16, 2021 • edited Loading

github-actions bot commented Mar 16, 2021 • edited Loading

github-actions bot commented Mar 16, 2021 • edited Loading

JacobDomagala Mar 16, 2021

Choose a reason for hiding this comment

JacobDomagala Mar 16, 2021

Choose a reason for hiding this comment

github-actions bot commented Mar 16, 2021 • edited Loading

github-actions bot commented Mar 16, 2021 • edited Loading

github-actions bot commented Mar 16, 2021 • edited Loading

lifflander left a comment

Choose a reason for hiding this comment

JacobDomagala commented Mar 25, 2021

PhilMiller Mar 30, 2021

Choose a reason for hiding this comment

lifflander left a comment

Choose a reason for hiding this comment

github-actions bot commented Mar 16, 2021 •

edited

Loading

github-actions bot commented Mar 16, 2021 •

edited

Loading

github-actions bot commented Mar 16, 2021 •

edited

Loading

github-actions bot commented Mar 16, 2021 •

edited

Loading

github-actions bot commented Mar 16, 2021 •

edited

Loading

github-actions bot commented Mar 16, 2021 •

edited

Loading

github-actions bot commented Mar 16, 2021 •

edited

Loading

github-actions bot commented Mar 16, 2021 •

edited

Loading

github-actions bot commented Mar 16, 2021 •

edited

Loading

github-actions bot commented Mar 16, 2021 •

edited

Loading

github-actions bot commented Mar 16, 2021 •

edited

Loading

github-actions bot commented Mar 16, 2021 •

edited

Loading

github-actions bot commented Mar 16, 2021 •

edited

Loading