Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1247: Generate clang 9/10 workflows for Azure #1365

Merged
merged 2 commits into from
Apr 8, 2021
Merged

1247: Generate clang 9/10 workflows for Azure #1365

merged 2 commits into from
Apr 8, 2021

Conversation

JacobDomagala
Copy link
Contributor

Fixes #1247

@JacobDomagala JacobDomagala self-assigned this Apr 7, 2021
@github-actions
Copy link

github-actions bot commented Apr 7, 2021 •
edited
Loading

PR tests (gcc-6, ubuntu, mpich)

Build for a9d8ce7

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented Apr 7, 2021 •
edited
Loading

PR tests (gcc-5, ubuntu, mpich)

Build for a9d8ce7

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented Apr 7, 2021 •
edited
Loading

PR tests (clang-3.9, ubuntu, mpich)

Build for a9d8ce7

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented Apr 7, 2021 •
edited
Loading

PR tests (clang-5.0, ubuntu, mpich)

Build for a9d8ce7

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented Apr 7, 2021 •
edited
Loading

PR tests (gcc-9, ubuntu, mpich, zoltan)

Build for a9d8ce7

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented Apr 7, 2021 •
edited
Loading

PR tests (clang-8, alpine, mpich)

Build for a9d8ce7

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented Apr 7, 2021 •
edited
Loading

PR tests (gcc-8, ubuntu, mpich, address sanitizer)

Build for a9d8ce7

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented Apr 7, 2021 •
edited
Loading

PR tests (gcc-10, ubuntu, openmpi, no LB)

Build for a9d8ce7

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented Apr 7, 2021 •
edited
Loading

PR tests (nvidia cuda 11.0, ubuntu, mpich)

Build for a9d8ce7

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented Apr 7, 2021 •
edited
Loading

PR tests (nvidia cuda 10.1, ubuntu, mpich)

Build for a9d8ce7

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented Apr 7, 2021 •
edited
Loading

PR tests (intel 18.03, ubuntu, mpich)

Build for a9d8ce7

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented Apr 7, 2021 •
edited
Loading

PR tests (intel 19, ubuntu, mpich)

Build for a9d8ce7

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented Apr 7, 2021 •
edited
Loading

PR tests (gcc-7, ubuntu, mpich, trace runtime, LB)

Build for a9d8ce7

Compilation - successful

Testing - passed

Build log

@JacobDomagala JacobDomagala force-pushed the 1247-add-clang9-and-clang10-builds branch 3 times, most recently from 686c0a4 to dee8332 Compare April 7, 2021 16:00
@github-actions
Copy link

github-actions bot commented Apr 7, 2021 •
edited
Loading

PR tests (clang-10, ubuntu, mpich)

Build for a9d8ce7

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented Apr 7, 2021 •
edited
Loading

PR tests (clang-9, ubuntu, mpich)

Build for a9d8ce7

Compilation - successful

Testing - passed

Build log

@JacobDomagala JacobDomagala marked this pull request as ready for review April 7, 2021 16:18
@JacobDomagala
Copy link
Contributor Author

Both Clang 9 and 10 are using default configuration. Do we want to add anything special for them?

@codecov
Copy link

codecov bot commented Apr 7, 2021 •
edited
Loading

Codecov Report

Merging #1365 (dee8332) into develop (0542da4) will increase coverage by 0.04%.
The diff coverage is n/a.

❗ Current head dee8332 differs from pull request most recent head a9d8ce7. Consider uploading reports for the commit a9d8ce7 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1365      +/-   ##
===========================================
+ Coverage    82.46%   82.50%   +0.04%     
===========================================
  Files          759      759              
  Lines        28279    28279              
===========================================
+ Hits         23321    23333      +12     
+ Misses        4958     4946      -12
Impacted Files Coverage Δ
src/vt/topos/location/location.impl.h 94.17% <0.00%> (+3.68%) ⬆️

cz4rs
cz4rs approved these changes Apr 7, 2021
View reviewed changes
Copy link
Contributor

@cz4rs cz4rs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@JacobDomagala JacobDomagala force-pushed the 1247-add-clang9-and-clang10-builds branch from dee8332 to a9d8ce7 Compare April 7, 2021 16:25
jstrzebonski
jstrzebonski approved these changes Apr 7, 2021
View reviewed changes
Copy link
Contributor

@jstrzebonski jstrzebonski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@cz4rs
Copy link
Contributor

cz4rs commented Apr 7, 2021

Both Clang 9 and 10 are using default configuration. Do we want to add anything special for them?

I assume that one of these can be used for #1352, but they look just fine at the moment 👍

lifflander
lifflander approved these changes Apr 7, 2021
View reviewed changes
Copy link
Collaborator

@lifflander lifflander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@JacobDomagala JacobDomagala merged commit cf9e1b3 into develop Apr 8, 2021
@cz4rs cz4rs mentioned this pull request Apr 13, 2021
Closed
@cz4rs cz4rs mentioned this pull request Jun 15, 2021
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lifflander lifflander lifflander approved these changes

@cz4rs cz4rs cz4rs approved these changes

@jstrzebonski jstrzebonski jstrzebonski approved these changes

Assignees

@JacobDomagala JacobDomagala

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add clang-9, clang-10 to CI
4 participants
@JacobDomagala @cz4rs @lifflander @jstrzebonski