1479: lib: Don't force fcontext to be STATIC lib

[JacobDomagala]

Fixes #1479

Without specified lib type, it will default to STATIC, but with BUILD_SHARED_LIBS set to ON, it will be built as SHARED.

[github-actions]

PR tests (gcc-5, ubuntu, mpich)

Build for d8d9dcc

Compilation - successful

Testing - passed

Build log

[github-actions]

PR tests (gcc-6, ubuntu, mpich)

Build for d8d9dcc

Compilation - successful

Testing - passed

Build log

[github-actions]

PR tests (clang-3.9, ubuntu, mpich)

Build for d8d9dcc

Compilation - successful

Testing - passed

Build log

[github-actions]

PR tests (clang-5.0, ubuntu, mpich)

Build for d8d9dcc

Compilation - successful

Testing - passed

Build log

[github-actions]

PR tests (gcc-8, ubuntu, mpich, address sanitizer)

Build for d8d9dcc

Compilation - successful

Testing - passed

Build log

[github-actions]

PR tests (gcc-10, ubuntu, openmpi, no LB)

Build for d8d9dcc

Compilation - successful

Testing - passed

Build log

[github-actions]

PR tests (gcc-9, ubuntu, mpich, zoltan)

Build for d8d9dcc

Compilation - successful

Testing - passed

Build log

[github-actions]

PR tests (nvidia cuda 10.1, ubuntu, mpich)

Build for d8d9dcc

Compilation - successful

Testing - passed

Build log

[github-actions]

PR tests (intel 18.03, ubuntu, mpich)

Build for d8d9dcc

Build failed for unknown reason. Check build logs

Build log

[github-actions]

PR tests (clang-9, ubuntu, mpich)

Build for d8d9dcc

Compilation - successful

Testing - passed

Build log

[github-actions]

PR tests (clang-10, alpine, mpich)

Build for d8d9dcc

Compilation - successful

Testing - passed

Build log

[github-actions]

PR tests (nvidia cuda 11.0, ubuntu, mpich)

Build for d8d9dcc

Compilation - successful

Testing - passed

Build log

[github-actions]

PR tests (intel 19, ubuntu, mpich)

Build for d8d9dcc

Build failed for unknown reason. Check build logs

Build log

[github-actions]

PR tests (clang-10, ubuntu, mpich)

Build for d8d9dcc

Compilation - successful

Testing - passed

Build log

[github-actions]

PR tests (gcc-7, ubuntu, mpich, trace runtime, LB)

Build for d8d9dcc

Compilation - successful

Testing - passed

Build log

[codecov]

Codecov Report

Merging #1481 (6f72a7d) into develop (af70685) will decrease coverage by 0.17%.
The diff coverage is n/a.

❗ Current head 6f72a7d differs from pull request most recent head d8d9dcc. Consider uploading reports for the commit d8d9dcc to get more accurate results

@@             Coverage Diff             @@
##           develop    #1481      +/-   ##
===========================================
- Coverage    83.00%   82.82%   -0.18%     
===========================================
  Files          783      765      -18     
  Lines        29505    28879     -626     
===========================================
- Hits         24490    23920     -570     
+ Misses        5015     4959      -56     

Impacted Files	Coverage Δ
tests/unit/collection/test_construct.cc	15.38% <0.00%> (-34.62%)	⬇️
src/vt/vrt/collection/send/sendable.impl.h	70.58% <0.00%> (-29.42%)	⬇️
.../unit/collection/test_construct_no_idx.extended.cc	22.22% <0.00%> (-27.78%)	⬇️
...unit/collection/test_collection_construct_common.h	14.63% <0.00%> (-10.37%)	⬇️
src/vt/vrt/collection/balance/node_stats.cc	75.81% <0.00%> (-7.77%)	⬇️
src/vt/group/collective/group_info_collective.cc	68.95% <0.00%> (-2.58%)	⬇️
src/vt/scheduler/base_unit.cc	77.77% <0.00%> (-2.23%)	⬇️
tests/unit/collection/test_lb.extended.cc	86.84% <0.00%> (-2.23%)	⬇️
src/vt/vrt/collection/messages/system_create.h	77.41% <0.00%> (-1.75%)	⬇️
src/vt/vrt/collection/manager.impl.h	94.74% <0.00%> (-1.72%)	⬇️
... and 142 more

[PhilMiller]

Please manually check that the resulting dynamic library builds, links, and loads happily on nvcc, since that's where this came up.

[JacobDomagala]

Builds fine with both VT_FCONTEXT_ENABLED, VT_FCONTEXT_BUILD_TESTS_EXAMPLES and DBUILD_SHARED_LIBS=ON on Ubuntu 18 with nvcc 10 docker image, but few tests are failing:

Just a note, that DBUILD_SHARED_LIBS=ON will try to build all libs as shared (see BUILD_SHARED_LIBS).

UPDATE: Failing tests seem to be unrelated to nvcc or shared libs. I'm getting same errors on Ubuntu 20 with clang-10. Weird

UPDATE_2: Memory footprint issues are not present when building with Unity, not sure why (this also explains why we don't face these issues on our CI, where we have both clang3.9 and gcc-6 with fcontext and Unity)

[cz4rs]

looks good to me, is that everything?