Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1512: cmake: check for when find_package exits early when part of parent #1516

Merged
merged 5 commits into from
Aug 10, 2021
Merged

#1512: cmake: check for when find_package exits early when part of parent #1516

merged 5 commits into from
Aug 10, 2021

Conversation

lifflander
Copy link
Collaborator

Fixes #1512

@github-actions
Copy link

github-actions bot commented Aug 4, 2021 •
edited
Loading

PR tests (intel 18.03, ubuntu, mpich)

Build for 8c5eb14

Build failed for unknown reason. Check build logs

Build log

@github-actions
Copy link

github-actions bot commented Aug 4, 2021 •
edited
Loading

PR tests (gcc-6, ubuntu, mpich)

Build for 8c5eb14

Build failed for unknown reason. Check build logs

Build log

@github-actions
Copy link

github-actions bot commented Aug 4, 2021 •
edited
Loading

PR tests (gcc-5, ubuntu, mpich)

Build for 8c5eb14

Build failed for unknown reason. Check build logs

Build log

@github-actions
Copy link

github-actions bot commented Aug 4, 2021 •
edited
Loading

PR tests (clang-5.0, ubuntu, mpich)

Build for 8c5eb14

Build failed for unknown reason. Check build logs

Build log

@github-actions
Copy link

github-actions bot commented Aug 4, 2021 •
edited
Loading

PR tests (clang-3.9, ubuntu, mpich)

Build for 8c5eb14

Build failed for unknown reason. Check build logs

Build log

@github-actions
Copy link

github-actions bot commented Aug 4, 2021 •
edited
Loading

PR tests (gcc-9, ubuntu, mpich, zoltan)

Build for 8c5eb14

Build failed for unknown reason. Check build logs

Build log

@github-actions
Copy link

github-actions bot commented Aug 4, 2021 •
edited
Loading

PR tests (gcc-8, ubuntu, mpich, address sanitizer)

Build for 8c5eb14

Build failed for unknown reason. Check build logs

Build log

@github-actions
Copy link

github-actions bot commented Aug 4, 2021 •
edited
Loading

PR tests (gcc-10, ubuntu, openmpi, no LB)

Build for 8c5eb14

Build failed for unknown reason. Check build logs

Build log

@github-actions
Copy link

github-actions bot commented Aug 4, 2021 •
edited
Loading

PR tests (intel 19, ubuntu, mpich)

Build for 8c5eb14

Build failed for unknown reason. Check build logs

Build log

@github-actions
Copy link

github-actions bot commented Aug 4, 2021 •
edited
Loading

PR tests (nvidia cuda 11.0, ubuntu, mpich)

Build for 1dd4726

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented Aug 4, 2021 •
edited
Loading

PR tests (nvidia cuda 10.1, ubuntu, mpich)

Build for 1dd4726

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented Aug 4, 2021 •
edited
Loading

PR tests (clang-9, ubuntu, mpich)

Build for 8c5eb14

Build failed for unknown reason. Check build logs

Build log

@github-actions
Copy link

github-actions bot commented Aug 4, 2021 •
edited
Loading

PR tests (clang-10, ubuntu, mpich)

Build for 8c5eb14

Build failed for unknown reason. Check build logs

Build log

@github-actions
Copy link

github-actions bot commented Aug 4, 2021 •
edited
Loading

PR tests (gcc-7, ubuntu, mpich, trace runtime, LB)

Build for 1dd4726

Compilation - successful

Testing - passed

Build log

@github-actions
Copy link

github-actions bot commented Aug 4, 2021 •
edited
Loading

PR tests (clang-10, alpine, mpich)

Build for 8c5eb14

Compilation - successful

Testing - passed

Build log

@lifflander lifflander force-pushed the 1512-fix-cmake-install-as-tpl branch from 458f4da to 59bca72 Compare August 10, 2021 19:04
@lifflander lifflander force-pushed the 1512-fix-cmake-install-as-tpl branch from 61c09bc to 8e21198 Compare August 10, 2021 21:18
@PhilMiller
Copy link
Member

I've manually confirmed that the things the Github Actions would check are all satisfied. Actions have an outage today, and we don't want to wait on them to recover to merge.

@codecov
Copy link

codecov bot commented Aug 10, 2021

Codecov Report

Merging #1516 (1dd4726) into develop (204a8dc) will decrease coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1516      +/-   ##
===========================================
- Coverage    82.88%   82.80%   -0.09%     
===========================================
  Files          780      780              
  Lines        29380    29380              
===========================================
- Hits         24353    24329      -24     
- Misses        5027     5051      +24
Impacted Files Coverage Δ
src/vt/vrt/collection/send/sendable.impl.h 63.15% <0.00%> (-36.85%) ⬇️
src/vt/vrt/collection/manager.h 88.00% <0.00%> (-12.00%) ⬇️
src/vt/vrt/collection/manager.impl.h 94.14% <0.00%> (-1.27%) ⬇️

@PhilMiller PhilMiller merged commit 5318749 into develop Aug 10, 2021
@PhilMiller PhilMiller deleted the 1512-fix-cmake-install-as-tpl branch August 10, 2021 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilMiller PhilMiller PhilMiller approved these changes

@cz4rs cz4rs Awaiting requested review from cz4rs

@nmm0 nmm0 Awaiting requested review from nmm0

@nlslatt nlslatt Awaiting requested review from nlslatt

@bathmatt bathmatt Awaiting requested review from bathmatt

@JacobDomagala JacobDomagala Awaiting requested review from JacobDomagala

@jstrzebonski jstrzebonski Awaiting requested review from jstrzebonski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CMake failure in application
2 participants
@lifflander @PhilMiller