#1393 add undefined behavior sanitizer #1556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstrzebonski
force-pushed
the
1393-add-ub-sanitizer
branch
from
82561cc to
f5b232f
Compare
PhilMiller
reviewed
Sep 15, 2021
jstrzebonski
force-pushed
the
1393-add-ub-sanitizer
branch
from
f5b232f to
8ed3ffb
Compare
PhilMiller
reviewed
Sep 15, 2021
PhilMiller
previously approved these changes
Sep 15, 2021
Codecov Report
@@ Coverage Diff @@
## develop #1556 +/- ##
===========================================
+ Coverage 82.90% 82.97% +0.07%
===========================================
Files 784 784
Lines 29741 29740 -1
===========================================
+ Hits 24657 24677 +20
+ Misses 5084 5063 -21
|
|
PR tests (clang-10, ubuntu, mpich, undefined behavior sanitizer) Build for a38c6ef |
jstrzebonski
force-pushed
the
1393-add-ub-sanitizer
branch
from
a63d96c to
a5bdd97
Compare
PhilMiller
reviewed
Oct 1, 2021
| @@ -36,6 +36,7 @@ variables: | |||
| VT_MIMALLOC: 0 | |||
| VT_DOCS: 0 | |||
| VT_ASAN: 0 | |||
| VT_UBSAN: 1 | |||
There was a problem hiding this comment.
The Unity build seems to be blowing up compilation. Perhaps it should be disabled for this case?
Things found by Undefined Behavior Sanitizer:
|
|
PR tests (clang-10, ubuntu, mpich) Build for a9e46ae |
PhilMiller
reviewed
Oct 2, 2021
jstrzebonski
changed the title
added 9 commits
October 5, 2021 22:18
jstrzebonski
force-pushed
the
1393-add-ub-sanitizer
branch
from
7e94f0c to
a9e46ae
Compare
jstrzebonski
requested review from
cz4rs,
lifflander,
JacobDomagala and
PhilMiller
and removed request for
PhilMiller,
lifflander,
cz4rs and
JacobDomagala
lifflander
approved these changes
Oct 5, 2021
PhilMiller
reviewed
Oct 8, 2021
| @@ -270,7 +270,7 @@ void StatsRestartReader::gatherMsgs(VecMsg *msg) { | |||
| proc_phase_runs_LB_[phaseID] = (!migrate.empty()); | |||
| auto& myList = proc_move_list_[phaseID]; | |||
| myList.resize(toMove.size() - header); | |||
| std::copy(&toMove[header], &toMove[0] + toMove.size(), | |||
| std::copy(&toMove[header], toMove.data() + toMove.size(), | |||
There was a problem hiding this comment.
Heh. If toMove.data() ever is nullptr, this is still going to end up being UB, because arithmetic on nullptr is also undefined.
That case is of course excluded by the fact that elements of toMove are written to in code just above this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1393
Fixes only
reference binding to null pointer, other errors are going to be fixed in separated PRs.